From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9871 invoked by alias); 18 Dec 2014 21:29:33 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 9858 invoked by uid 89); 18 Dec 2014 21:29:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Dec 2014 21:29:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBILT4Km027227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 18 Dec 2014 16:29:04 -0500 Received: from pike.twiddle.home (vpn-57-19.rdu2.redhat.com [10.10.57.19]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBILT3U0027555; Thu, 18 Dec 2014 16:29:03 -0500 Message-ID: <5493471D.4020506@redhat.com> Date: Thu, 18 Dec 2014 21:29:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: libffi-discuss@sourceware.org, Ulrich Weigand , Andreas Krebbel Subject: Re: [PATCH] Go closures for s390[x] References: <20141216150504.GA10835@linux.vnet.ibm.com> In-Reply-To: <20141216150504.GA10835@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00264.txt.bz2 On 12/16/2014 09:05 AM, Dominik Vogt wrote: > lm %r6,%r15,48+24(%r11) > + .cfi_remember_state > + .cfi_restore 15 > + .cfi_restore 14 > + .cfi_restore 13 > + .cfi_restore 12 > + .cfi_restore 11 > + .cfi_restore 10 > + .cfi_restore 9 > + .cfi_restore 8 > + .cfi_restore 7 > + .cfi_restore 6 > + .cfi_def_cfa r15, 96 > br %r4 > + .cfi_restore_state > + # This nopr is necessary so that the .cfi instructions between the br > + # above and the label below get executed. See execute_cfa_program() in > + # the Gcc source code, libgcc/unwind-dw2.c. > + nopr I'm not really sure you need any of these restores, since the data is still on the stack, unclobbered. I think you'd really only need to reset the cfa here. The nopr seems like a red herring. I don't see why the < vs <= for execute_cfa_program is relevant -- this is not following a call. That said, I've got some followup patches to clean up more of the s390 backend that I'll post in a moment. r~