* armhf testsuite failures possibly due to 7ad0ae7f42
@ 2017-10-23 9:53 Kyrill Tkachov
2017-10-24 0:35 ` Saleem Abdulrasool
0 siblings, 1 reply; 4+ messages in thread
From: Kyrill Tkachov @ 2017-10-23 9:53 UTC (permalink / raw)
To: libffi-discuss; +Cc: compnerd
Hi all,
Matthias' testing of libffi [1] (thanks!) shows some recent failures on
armhf relating to closures with short types
(search for "FAIL:")
Considering that the results from May look okay I suspect the culprit is
commit 7ad0ae7f42f3e208431ab66a9032dc9549f978d0 (arm: zext return value
parameters)
from Oct 10.
Would it be possible to take a look and fix the failures?
Thanks,
Kyrill
(Please keep me on CC to any replies as I am not subscribed to this list)
[1]
https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20171020-1&stamp=1508524302&raw=0
[2]
https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20170512-1&stamp=1494644748&raw=0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: armhf testsuite failures possibly due to 7ad0ae7f42
2017-10-23 9:53 armhf testsuite failures possibly due to 7ad0ae7f42 Kyrill Tkachov
@ 2017-10-24 0:35 ` Saleem Abdulrasool
2017-10-25 0:20 ` Saleem Abdulrasool
0 siblings, 1 reply; 4+ messages in thread
From: Saleem Abdulrasool @ 2017-10-24 0:35 UTC (permalink / raw)
To: Kyrill Tkachov, libffi-discuss
On Mon, Oct 23, 2017 at 2:53 AM Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
wrote:
> Hi all,
>
> Matthias' testing of libffi [1] (thanks!) shows some recent failures on
> armhf relating to closures with short types
> (search for "FAIL:")
>
> Considering that the results from May look okay I suspect the culprit is
> commit 7ad0ae7f42f3e208431ab66a9032dc9549f978d0 (arm: zext return value
> parameters)
> from Oct 10.
> Would it be possible to take a look and fix the failures?
>
Thanks for the notification.
Yeah, the tests probably need to be adjusted. The tests look like
something which would be impacted by the zext. It was previously sending
whatever was in the register previously.
> Thanks,
> Kyrill
>
> (Please keep me on CC to any replies as I am not subscribed to this list)
>
> [1]
>
> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20171020-1&stamp=1508524302&raw=0
>
> [2]
>
> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20170512-1&stamp=1494644748&raw=0
>
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: armhf testsuite failures possibly due to 7ad0ae7f42
2017-10-24 0:35 ` Saleem Abdulrasool
@ 2017-10-25 0:20 ` Saleem Abdulrasool
2017-10-25 8:15 ` Kyrill Tkachov
0 siblings, 1 reply; 4+ messages in thread
From: Saleem Abdulrasool @ 2017-10-25 0:20 UTC (permalink / raw)
To: Kyrill Tkachov, libffi-discuss
Hey, it was a silly bug caused by a level of indirection thing. I sent a
PR (381) on github to address the issue. It passes the tests locally.
On Mon, Oct 23, 2017 at 5:35 PM Saleem Abdulrasool <compnerd@compnerd.org>
wrote:
> On Mon, Oct 23, 2017 at 2:53 AM Kyrill Tkachov <
> kyrylo.tkachov@foss.arm.com> wrote:
>
>> Hi all,
>>
>> Matthias' testing of libffi [1] (thanks!) shows some recent failures on
>> armhf relating to closures with short types
>> (search for "FAIL:")
>>
>> Considering that the results from May look okay I suspect the culprit is
>> commit 7ad0ae7f42f3e208431ab66a9032dc9549f978d0 (arm: zext return value
>> parameters)
>> from Oct 10.
>> Would it be possible to take a look and fix the failures?
>>
>
> Thanks for the notification.
>
> Yeah, the tests probably need to be adjusted. The tests look like
> something which would be impacted by the zext. It was previously sending
> whatever was in the register previously.
>
>
>> Thanks,
>> Kyrill
>>
>> (Please keep me on CC to any replies as I am not subscribed to this list)
>>
>> [1]
>>
>> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20171020-1&stamp=1508524302&raw=0
>>
>> [2]
>>
>> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20170512-1&stamp=1494644748&raw=0
>>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: armhf testsuite failures possibly due to 7ad0ae7f42
2017-10-25 0:20 ` Saleem Abdulrasool
@ 2017-10-25 8:15 ` Kyrill Tkachov
0 siblings, 0 replies; 4+ messages in thread
From: Kyrill Tkachov @ 2017-10-25 8:15 UTC (permalink / raw)
To: Saleem Abdulrasool, libffi-discuss
On 25/10/17 01:20, Saleem Abdulrasool wrote:
> Hey, it was a silly bug caused by a level of indirection thing. I
> sent a PR (381) on github to address the issue. It passes the tests
> locally.
>
Thanks for looking into it!
Kyrill
> On Mon, Oct 23, 2017 at 5:35 PM Saleem Abdulrasool
> <compnerd@compnerd.org <mailto:compnerd@compnerd.org>> wrote:
>
> On Mon, Oct 23, 2017 at 2:53 AM Kyrill Tkachov
> <kyrylo.tkachov@foss.arm.com <mailto:kyrylo.tkachov@foss.arm.com>>
> wrote:
>
> Hi all,
>
> Matthias' testing of libffi [1] (thanks!) shows some recent
> failures on
> armhf relating to closures with short types
> (search for "FAIL:")
>
> Considering that the results from May look okay I suspect the
> culprit is
> commit 7ad0ae7f42f3e208431ab66a9032dc9549f978d0 (arm: zext
> return value
> parameters)
> from Oct 10.
> Would it be possible to take a look and fix the failures?
>
>
> Thanks for the notification.
>
> Yeah, the tests probably need to be adjusted. The tests look like
> something which would be impacted by the zext. It was previously
> sending whatever was in the register previously.
>
>
> Thanks,
> Kyrill
>
> (Please keep me on CC to any replies as I am not subscribed to
> this list)
>
> [1]
> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20171020-1&stamp=1508524302&raw=0
> <https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3%7E20171020-1&stamp=1508524302&raw=0>
>
> [2]
> https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3~20170512-1&stamp=1494644748&raw=0
> <https://buildd.debian.org/status/fetch.php?pkg=libffi&arch=armhf&ver=3.3%7E20170512-1&stamp=1494644748&raw=0>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-25 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 9:53 armhf testsuite failures possibly due to 7ad0ae7f42 Kyrill Tkachov
2017-10-24 0:35 ` Saleem Abdulrasool
2017-10-25 0:20 ` Saleem Abdulrasool
2017-10-25 8:15 ` Kyrill Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).