From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id E352A3858CD1 for ; Thu, 26 Oct 2023 13:32:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E352A3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E352A3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698327176; cv=none; b=hB3o94kHZ4T4f7DRkhG5wx2PyStwXy/IfGgcOZQWZ6mdBg0ywUot83VciV2MM3EE825x9U5aWPfXoektVs1soCckkp8FeLn3tbaXOuvSYopim6uU3AtxfrUDlSwXsND0apiVBQhdtL1bypCYZJID0wYXwvh3uutL3FYlqBTlVD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698327176; c=relaxed/simple; bh=sNvXLJYNEGPoJ7xEz299D8kHW2Z4NUDJJMGYakc0e7M=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sh2F5b9hoBv9NKz/WGGWpus/OTBLwb1oXj8RCxW1ih78khShxE1r2jYoSC+9ZQguAop5rByO+kfQY9YuuGZzvCpLW7UddLPKIrvxGcfHIDha9jnc2UvdNQSca8XL9UY7hz0FkGX254I197LT1c+v/iQ11fOrYU5q+GU0n/BbcrA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-27d0acd0903so746232a91.1 for ; Thu, 26 Oct 2023 06:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698327174; x=1698931974; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ekFgwKBaJC2uIfcQ8jKBQOXDoYMCgKyh0lWaprgipWk=; b=Mnk4jt20McHC9utuKcME36AgF+awxYwkdi5E4RX0WMlVxwBeczO6STSHFttHjrnsPh gPJ1bqq5wG+X4aPF/EJPKZxipWULhE2rGKvjHtxEzMDqG4MZwr7cBkaRdAe4QiY9a1aZ axgagxFcMzZ+bgEnFlVsRcCT2GGqI/BMLPS1yEys9Tx5S3DlBIM8fLNBFRBS2PNZEfIh 1TVKXA8Q8gkmFM0gyx6SCLXZeyd8gmtl4noMIM2RXm5IcvG5UIb57Nxi+DXVXSB0K8BJ 7MlhGy3k6rmdkn+ny+m7gUrQQEfin71cp3xU7mrnWG7llQJ6ugcqYgjONk65CxayftKi nBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698327174; x=1698931974; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ekFgwKBaJC2uIfcQ8jKBQOXDoYMCgKyh0lWaprgipWk=; b=GIEPD2KObJZ6+bzeVnZerjUH8ghnlNqNID9jI1gVaK0wCb7G2ghIe/Kot694qzlKqy VdPWZndSxBteNEuZBtAazuuu26azCOfgnzZQUq/AAVh4xWoj1w1f36e3ugzgAYzyyZhf SLyQNkJHgOsg3d+ef11EBO5TCCJAeNjORfjlA5Cj1DJtbEm+IgSbxHysceo/EuvpNK3/ yRAsf1NzqBFNh3kDWuvd/ND2X4vWJFjTTn8cwVrouOpOXnt5Nw2clgMF1pvCPhMe4bWQ Mzg5viI3oz+pRdZKTi3+5K2A/VTu/I3cb/1VRYC724xqzHg18U7yUjfHQFJjAkI7jDAk OjGQ== X-Gm-Message-State: AOJu0YwQVvIewojJFNJYGhs4sesBdpi64GRV1OACquz9fKLC8Uf28lFf ewcWPS2Jjq4+u1X1Z2err2g= X-Google-Smtp-Source: AGHT+IEkHFO0aGGqgmQuMlE8buqNElK67m3So/N5aCAUNnHmWaTVZBBXPBDtS43HSYSd178qAb8Zag== X-Received: by 2002:a17:90a:c297:b0:27c:f483:e2da with SMTP id f23-20020a17090ac29700b0027cf483e2damr16620303pjt.5.1698327173636; Thu, 26 Oct 2023 06:32:53 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id fa12-20020a17090af0cc00b00274b035246esm1953328pjb.1.2023.10.26.06.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 06:32:53 -0700 (PDT) Message-ID: <5bf12011-0f62-4c31-bb3a-ae121493cb79@gmail.com> Date: Thu, 26 Oct 2023 07:32:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING] libffi: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951] Content-Language: en-US To: Thomas Schwinge , gcc-patches@gcc.gnu.org Cc: Iain Sandoe , libffi-discuss@sourceware.org, "Maciej W. Rozycki" References: <871qf3zmi4.fsf@euler.schwinge.homeip.net> <87y1frw1db.fsf@euler.schwinge.homeip.net> From: Jeff Law In-Reply-To: <87y1frw1db.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/25/23 02:30, Thomas Schwinge wrote: > Hi! > > Ping. > > > Grüße > Thomas > > > On 2023-09-12T12:58:27+0200, I wrote: >> Hi! >> >> On 2020-04-20T14:18:40+0100, "Maciej W. Rozycki via Gcc-patches" wrote: >>> Fix a problem with the libffi testsuite using a method to determine the >>> compiler to use resulting in the tool being different from one the >>> library has been built with, and causing a catastrophic failure from the >>> inability to actually choose any compiler at all in a cross-compilation >>> configuration. >> >> This has since, as far as I can tell, been resolved properly by H.J. Lu's >> GCC commit 5be7b66998127286fada45e4f23bd8a2056d553e, >> "libffi: Integrate build with GCC", and >> GCC commit 4824ed41ba7cd63e60fd9f8769a58b79935a90d1 >> "libffi: Integrate testsuite with GCC testsuite". >> >>> Address this problem by providing a DejaGNU configuration file defining >>> the compiler to use, via the CC_FOR_TARGET TCL variable, set from $CC by >>> autoconf, which will have all the required options set for the target >>> compiler to build executables in the environment configured >> >> As we've found, this is conceptually problematic, as discussed in >> >> "Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951]". >> I therefore suggest to apply to GCC libffi the conceptually same changes >> as I've just pushed for libgomp: >> >> "libgomp: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR91884, PR109951]". >> OK to push the attached >> "libffi: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951]"? OK (patch didn't appear inline, but hopefully you've got enough context to know it's the libffi bits getting ACK'd). jeff