From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <madvenka@linux.microsoft.com>
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by sourceware.org (Postfix) with ESMTP id 41380385781D
 for <libffi-discuss@sourceware.org>; Fri,  5 Feb 2021 18:20:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 41380385781D
Received: from [192.168.254.32] (unknown [47.187.219.45])
 by linux.microsoft.com (Postfix) with ESMTPSA id 3F39120B6C40;
 Fri,  5 Feb 2021 10:20:30 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3F39120B6C40
Subject: Re: [RFC PATCH v3 0/5] Libffi Static Trampolines
From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
To: Anthony Green <green@moxielogic.com>
Cc: libffi-discuss <libffi-discuss@sourceware.org>, fweimer@redhat.com,
 DJ Delorie <dj@redhat.com>
References: <20210115184653.124913-1-madvenka@linux.microsoft.com>
 <CACxje5-zmPysuo6yPskbXXCxQoe-gF6j0oSxfXOg3zZZNRp+tQ@mail.gmail.com>
 <849643ba-5c3e-31e6-b784-d0fc2345ce00@linux.microsoft.com>
 <CACxje5_WshA6Zi6pBjeCFChfw5zFr+kS763aX0Te5SC2_WFmtw@mail.gmail.com>
 <811113c4-7bda-ee21-cdb9-4ab20d1fd291@linux.microsoft.com>
 <CACxje5-bD3jJQK8kX91=zuGdbaFAHSQaamgnoFPW0dAm7X3CkA@mail.gmail.com>
 <e294e952-09d2-6a32-fe7a-f449df5702b8@linux.microsoft.com>
Message-ID: <78796ef0-d66b-81e5-d029-5299ff3a4028@linux.microsoft.com>
Date: Fri, 5 Feb 2021 12:20:29 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e294e952-09d2-6a32-fe7a-f449df5702b8@linux.microsoft.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-20.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, ENV_AND_HDR_SPF_MATCH, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libffi-discuss@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libffi-discuss mailing list <libffi-discuss.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libffi-discuss>,
 <mailto:libffi-discuss-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libffi-discuss/>
List-Post: <mailto:libffi-discuss@sourceware.org>
List-Help: <mailto:libffi-discuss-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libffi-discuss>,
 <mailto:libffi-discuss-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2021 18:20:32 -0000

Hi Anthony,

>> In this case, my ask is that you split this into two patches.  The first one, (a), I would like to merge as soon as it seems ready.  
>>
> 
> OK. I will remove the public API part, sync with the latest libffi and submit a PR.
> 

I have removed the public API. I have pushed the latest changes in static_tramp_v4.
I have addressed all the comments from DJ Delorie (Thanks DJ!!!).

The current patchset contains support for X64, i386, arm64 and arm for Linux.
I will add BSD support in a separate patch once this gets accepted.

>>
>> Also, please use the github PR process for the next round so we can get some automated CI going.  And I prefer reviewing patches within the github UI, tbh.

I have created the PR. Please review.

Do I also need to send the patchset to the libffi alias? Please advise.

Thanks.

Madhavan