* Fix Q registers parameter passing on ARM64
@ 2018-11-29 14:27 Martin Bekchiev
2018-11-29 17:52 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Martin Bekchiev @ 2018-11-29 14:27 UTC (permalink / raw)
To: libffi-discuss
Hi everyone,
I opened a PR with a very small fix on ARM64 architecture about a month ago. Can someone with commit rights please review and merge it?
https://github.com/libffi/libffi/pull/457
Thanks in advance and best wishes,
Martin Bektchiev
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix Q registers parameter passing on ARM64
2018-11-29 14:27 Fix Q registers parameter passing on ARM64 Martin Bekchiev
@ 2018-11-29 17:52 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2018-11-29 17:52 UTC (permalink / raw)
To: Martin Bekchiev; +Cc: libffi-discuss
>>>>> "Martin" == Martin Bekchiev <Martin.Bektchiev@progress.com> writes:
Martin> I opened a PR with a very small fix on ARM64 architecture about a month ago. Can someone with commit rights please review and merge it?
Martin> https://github.com/libffi/libffi/pull/457
You pinged me for review and I dropped it. Sorry about that. Emailing
here is the right thing to do.
I don't know anything about ARM64 and so I was reluctant to merge it.
Could you possibly add a new regression test? Also, I'm wondering if
you re-ran the existing test suite after your change.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-29 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 14:27 Fix Q registers parameter passing on ARM64 Martin Bekchiev
2018-11-29 17:52 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).