From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107254 invoked by alias); 29 Nov 2018 17:52:31 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 107236 invoked by uid 89); 29 Nov 2018 17:52:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*Ad:U*libffi-discuss, emailing, Emailing, Hx-languages-length:619 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 17:52:28 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id D5F7112E70B for ; Thu, 29 Nov 2018 11:52:25 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SQUDgr4axSjJASQUDgEEiy; Thu, 29 Nov 2018 11:52:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=776z4LzGB/YyryFba+z8UuVQPGXjgN1Er+FnGU43VxU=; b=DETREzsdR+UMGGcVxgAxxPrHem ACXJ4SAyW4hC4JxXHhZ7aPZCKbuU8wR9jNeK6dBSubAEySLRkXdJbfOLRKTIodWBePwDM1QZn+QzK MmUnpiONSsw9iiRqMBgO9wwK/; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:55344 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSQUD-0011Pu-DU; Thu, 29 Nov 2018 11:52:25 -0600 From: Tom Tromey To: Martin Bekchiev Cc: "libffi-discuss\@sourceware.org" Subject: Re: Fix Q registers parameter passing on ARM64 References: Date: Thu, 29 Nov 2018 17:52:00 -0000 In-Reply-To: (Martin Bekchiev's message of "Thu, 29 Nov 2018 14:27:50 +0000") Message-ID: <87bm6793fr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018/txt/msg00045.txt.bz2 >>>>> "Martin" == Martin Bekchiev writes: Martin> I opened a PR with a very small fix on ARM64 architecture about a month ago. Can someone with commit rights please review and merge it? Martin> https://github.com/libffi/libffi/pull/457 You pinged me for review and I dropped it. Sorry about that. Emailing here is the right thing to do. I don't know anything about ARM64 and so I was reluctant to merge it. Could you possibly add a new regression test? Also, I'm wondering if you re-ran the existing test suite after your change. Tom