From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126576 invoked by alias); 17 Sep 2017 14:24:58 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 126565 invoked by uid 89); 17 Sep 2017 14:24:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*Ad:U*libffi-discuss, HTo:U*rth, H*Ad:U*rth, sk:schwab X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Sep 2017 14:24:48 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3xwBH13MQRz1qqyg; Sun, 17 Sep 2017 16:24:45 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3xwBH11fjZz1qqkC; Sun, 17 Sep 2017 16:24:45 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Po3sI7PuESnV; Sun, 17 Sep 2017 16:24:44 +0200 (CEST) X-Auth-Info: coV59VmFi629DmltnQ9ytm+hzHHoZG+bJBM+p5pWybJGQw+iKUwjPjWBN5dbUqaK Received: from igel.home (ppp-88-217-5-81.dynamic.mnet-online.de [88.217.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 17 Sep 2017 16:24:44 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id CAA3F2C4C85; Sun, 17 Sep 2017 16:24:43 +0200 (CEST) From: Andreas Schwab To: Richard Henderson Cc: libffi-discuss@sourceware.org, Richard Henderson Subject: Re: [PATCH 08/16] aarch64: Tidy up abi manipulation References: <1414522393-19169-1-git-send-email-rth@twiddle.net> <1414522393-19169-9-git-send-email-rth@twiddle.net> X-Yow: OMNIVERSAL AWARENESS?? Oh, YEH!! First you need 4 GALLONS of JELL-O and a BIG WRENCH!!... I think you drop th'WRENCH in the JELL-O as if it was a FLAVOR, or an INGREDIENT... ...or...I...um... WHERE'S the WASHING MACHINES? Date: Sun, 17 Sep 2017 14:24:00 -0000 In-Reply-To: <1414522393-19169-9-git-send-email-rth@twiddle.net> (Richard Henderson's message of "Tue, 28 Oct 2014 11:53:05 -0700") Message-ID: <87efr5fln8.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017/txt/msg00018.txt.bz2 On Okt 28 2014, Richard Henderson wrote: > + case FFI_TYPE_STRUCT: > + { > + void *dest; > + int elems; > + > + h = is_hfa (ty); > + if (h) > + { > + do_hfa: > + elems = h >> 8; > + if (state.nsrn + elems <= N_V_ARG_REG) > + { > + dest = &context->v[state.nsrn]; > + state.nsrn += elems; > + extend_hfa_type (dest, a, h); > + break; > + } > + state.nsrn = N_V_ARG_REG; > + dest = allocate_to_stack (&state, stack, ty->alignment, s); > + } > + else if (s > 16) > + { > + /* If the argument is a composite type that is larger than 16 > + bytes, then the argument has been copied to memory, and > + the argument is replaced by a pointer to the copy. */ > + a = &avalue[i]; > + t = FFI_TYPE_POINTER; > + goto do_pointer; I don't see where the argument has been copied to memory. Doesn't that need to call allocate_to_stack here? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."