public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Bruno Haible <bruno@clisp.org>
Cc: "Kaz Kylheku \(libffi\)" <382-725-6798@kylheku.com>,
	 libffi-discuss@sourceware.org
Subject: Re: small return types
Date: Wed, 25 Oct 2017 05:18:00 -0000	[thread overview]
Message-ID: <87po9brejj.fsf@tromey.com> (raw)
In-Reply-To: <5182570.xx5xnuqjYz@omega> (Bruno Haible's message of "Sun, 22	Oct 2017 22:33:04 +0200")

>>>>> "Bruno" == Bruno Haible <bruno@clisp.org> writes:

Bruno> Changing the subject, since we're talking about
Bruno> https://github.com/libffi/libffi/issues/361
Bruno> https://github.com/libffi/libffi/issues/362
Bruno> https://github.com/libffi/libffi/issues/368
Bruno> https://github.com/libffi/libffi/issues/369

>> Naively written code will appear to work fine on little endian 64 bit,

Bruno> No, the bug https://github.com/libffi/libffi/issues/368 also affect
Bruno> some little-endian platforms.

It sounds this one is a different bug.  I haven't looked at your test
suite yet, so no speculation from me about what it might be.

For the others, I think we should close them; or perhaps close all but
one of them and change the last one into a libffi 4 wish-list bug.

Kaz's analysis here is, I believe, correct -- libffi is it the way it
is, and the tests should be changed.  Changing libffi is probably a good
idea, but it will also break the current users, so it would be best to
roll this sort of change up with other desirable breaking changes.  And,
as you can probably see, there isn't a huge amount of work going on in
libffi, so it's unclear to me at least whether this could be
accomplished for the existing targets.

Tom

      parent reply	other threads:[~2017-10-25  5:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-21 18:31 test results on many platforms Bruno Haible
2017-10-22  8:12 ` Matthias Klose
2017-10-22 14:58   ` Bruno Haible
2017-10-22 18:28 ` Kaz Kylheku (libffi)
2017-10-22 20:33   ` small return types Bruno Haible
2017-10-22 21:38     ` Kaz Kylheku (libffi)
2017-10-25  5:18     ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po9brejj.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=382-725-6798@kylheku.com \
    --cc=bruno@clisp.org \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).