From: Anthony Green <green@moxielogic.com>
To: Will Newton <will.newton@linaro.org>
Cc: libffi-discuss@sourceware.org, patches@linaro.org
Subject: Re: [PATCH] src/arm/sysv.S: Fix ffi_call_VFP with no VFP arguments
Date: Fri, 28 Feb 2014 05:28:00 -0000 [thread overview]
Message-ID: <87sir3iz68.fsf@moxielogic.com> (raw)
In-Reply-To: <1390318359-4608-1-git-send-email-will.newton@linaro.org> (Will Newton's message of "Tue, 21 Jan 2014 15:32:39 +0000")
Will Newton <will.newton@linaro.org> writes:
> When no VFP arguments are present the IP register is used
> uninitialized. Initialize it to the value of FP.
>
> This fixes a number of testsuite failures when configured for
> armv7l-unknown-linux-gnueabihf:
Thanks Will!
AG
>
> FAIL: libffi.call/cls_3byte1.c -O0 -W -Wall execution test
> FAIL: libffi.call/cls_3byte2.c -O0 -W -Wall execution test
> FAIL: libffi.call/cls_4_1byte.c -O0 -W -Wall execution test
> FAIL: libffi.call/cls_4byte.c -O0 -W -Wall execution test
> FAIL: libffi.call/cls_3byte1.c -O2 execution test
> FAIL: libffi.call/cls_3byte2.c -O2 execution test
> FAIL: libffi.call/cls_4_1byte.c -O2 execution test
> FAIL: libffi.call/cls_4byte.c -O2 execution test
> FAIL: libffi.call/cls_3byte1.c -O3 execution test
> FAIL: libffi.call/cls_3byte2.c -O3 execution test
> FAIL: libffi.call/cls_4_1byte.c -O3 execution test
> FAIL: libffi.call/cls_4byte.c -O3 execution test
> FAIL: libffi.call/cls_3byte1.c -Os execution test
> FAIL: libffi.call/cls_3byte2.c -Os execution test
> FAIL: libffi.call/cls_4_1byte.c -Os execution test
> FAIL: libffi.call/cls_4byte.c -Os execution test
> FAIL: libffi.call/cls_3byte1.c -O2 -fomit-frame-pointer execution test
> FAIL: libffi.call/cls_3byte2.c -O2 -fomit-frame-pointer execution test
> FAIL: libffi.call/cls_4_1byte.c -O2 -fomit-frame-pointer execution test
> FAIL: libffi.call/cls_4byte.c -O2 -fomit-frame-pointer execution test
> ---
> src/arm/sysv.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/arm/sysv.S b/src/arm/sysv.S
> index 454dfc9..8ab6d63 100644
> --- a/src/arm/sysv.S
> +++ b/src/arm/sysv.S
> @@ -368,6 +368,7 @@ ARM_FUNC_START ffi_call_VFP
>
> @ Load VFP register args if needed
> cmp r0, #0
> + mov ip, fp
> beq LSYM(Lbase_args)
>
> @ Load only d0 if possible
prev parent reply other threads:[~2014-02-28 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 15:32 Will Newton
2014-02-28 5:28 ` Anthony Green [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sir3iz68.fsf@moxielogic.com \
--to=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
--cc=patches@linaro.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).