From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18587 invoked by alias); 20 Sep 2014 10:37:39 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 18575 invoked by uid 89); 20 Sep 2014 10:37:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-qc0-f182.google.com Received: from mail-qc0-f182.google.com (HELO mail-qc0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 20 Sep 2014 10:37:37 +0000 Received: by mail-qc0-f182.google.com with SMTP id i8so3584783qcq.41 for ; Sat, 20 Sep 2014 03:37:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=e/VxOv7VL88kp9GvXvqfEeh16MD4yeYlsAMSA9lIbtY=; b=mnvkOqiMe+MnoKZMBoiAnh3uh9DNbkomYuAfxGiAzsC40lJJ5rKt4TS1GuIo+7iwMy hUPqcKVM3d30g4JHJZdDFIGnVLRfn40yZUsYAh0Glex4UdzbNQdLJXBnGnVnjIM2X95k 0cA8i+PUYJ26UBzp6bdYv25D+getyQLlV7SqIKha/6DNgigs804se0TeZ6IEqOV/EmPI rcwQafbFSy/70LgTOWtUwfPhqa6HqPr8s0+GrMTQCynykI1q3n31qIn0FMUQB1hk+6oA RsstKyVKQMZL/5WbOkHdFiazyUHX2B/RFr4MFPoVADiTxATSqvtLLkx1SzfNb9PT8V2c FNfw== X-Gm-Message-State: ALoCoQmpNDJyq53Ym4xYINiVbmEP+p7t6EKBsr1iHDgCj5hpRMovOYBfuP9TN4GaFk1Y5ScixqxN X-Received: by 10.224.74.67 with SMTP id t3mr895385qaj.100.1411209455951; Sat, 20 Sep 2014 03:37:35 -0700 (PDT) Received: from localhost (CPE687f74122463-CM84948c2e0610.cpe.net.cable.rogers.com. [99.226.94.59]) by mx.google.com with ESMTPSA id q11sm3390936qay.37.2014.09.20.03.37.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Sep 2014 03:37:34 -0700 (PDT) From: Anthony Green To: Matthias Klose Cc: "libffi-discuss\@sourceware.org" Subject: Re: [patch] fix build error with -Werror=declaration-after-statement References: <53E76EA8.5000804@ubuntu.com> Date: Sat, 20 Sep 2014 10:37:00 -0000 In-Reply-To: <53E76EA8.5000804@ubuntu.com> (Matthias Klose's message of "Sun, 10 Aug 2014 15:07:52 +0200") Message-ID: <87tx42h91u.fsf@moxielogic.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00086.txt.bz2 Matthias Klose writes: > seen while merging the 3.1 release into the python sources. The build fails when > built with -Werror=declaration-after-statement Thanks, Matthias. Committed. > > Matthias > > diff -urN libffi-3.1/src/arm/ffi.c libffi/src/arm/ffi.c > --- libffi-3.1/src/arm/ffi.c Sat Aug 09 23:52:34 2014 +0200 > +++ libffi/src/arm/ffi.c Sat Aug 09 23:58:38 2014 +0200 > @@ -154,9 +154,6 @@ > > int ffi_prep_args_VFP(char *stack, extended_cif *ecif, float *vfp_space) > { > - // make sure we are using FFI_VFP > - FFI_ASSERT(ecif->cif->abi == FFI_VFP); > - > register unsigned int i, vi = 0; > register void **p_argv; > register char *argp, *regp, *eo_regp; > @@ -165,6 +162,9 @@ > char done_with_regs = 0; > char is_vfp_type; > > + // make sure we are using FFI_VFP > + FFI_ASSERT(ecif->cif->abi == FFI_VFP); > + > /* the first 4 words on the stack are used for values passed in core > * registers. */ > regp = stack;