From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23861 invoked by alias); 23 Feb 2011 16:20:50 -0000 Received: (qmail 23847 invoked by uid 22791); 23 Feb 2011 16:20:47 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Feb 2011 16:20:43 +0000 Received: by qwd7 with SMTP id 7so3969247qwd.0 for ; Wed, 23 Feb 2011 08:20:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.212.138 with SMTP id gs10mr527707qab.157.1298478041470; Wed, 23 Feb 2011 08:20:41 -0800 (PST) Received: by 10.224.205.134 with HTTP; Wed, 23 Feb 2011 08:20:41 -0800 (PST) In-Reply-To: <4D650ADE.6040609@linaro.org> References: <20110222154022.GA29862@davesworkthinkpad> <4D650ADE.6040609@linaro.org> Date: Wed, 23 Feb 2011 16:20:00 -0000 Message-ID: Subject: Re: [PATCH] Add variadic support From: David Gilbert To: Chung-Lin Tang Cc: Anthony Green , libffi-discuss@sourceware.org, Marcus.Shawcroft@arm.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2011/txt/msg00079.txt.bz2 On 23 February 2011 13:25, Chung-Lin Tang wrote: > On 2011/2/23 09:11 PM, David Gilbert wrote: >> In ARM's ffi_prep_cif_machdep I have: >> >> +#ifdef __ARM_PCS_VFP >> + =A0/* VFP uses the standard ABI for variadic functions */ >> + =A0if ((cif->abi =3D=3D FFI_VFP) && (cif->nfixedargs !=3D 0)) >> + =A0 =A0cif->abi =3D FFI_SYSV; >> +#endif >> >> and that's the only active change that's needed. > > I suggest removing the #ifdef __ARM_PCS_VFP #ifdef. =A0We always have > support for both FFI_SYSV and FFI_VFP compiled in, so it doesn't make > sense to leave this bit of logic out when we are under __ARM_PCS. I could do, although cif->nfixedargs is also not present except in the VFP case, so it would still need an ifdef. I did that since I thought it best not to change the layout of the CIF structure for existing ARM builds. Dave