public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: David Gilbert <david.gilbert@linaro.org>
To: Anthony Green <green@redhat.com>
Cc: libffi-discuss@sourceware.org, Marcus.Shawcroft@arm.com,
	cltang@linaro.org
Subject: Re: PowerPC failures (Was: [PATCH] Add variadic support)
Date: Thu, 24 Feb 2011 10:43:00 -0000	[thread overview]
Message-ID: <AANLkTinvwPkFFq11jwrStGNBdsj9k8j527+h0+Da81TC@mail.gmail.com> (raw)
In-Reply-To: <m3sjvelabx.fsf@redhat.com>

On 23 February 2011 21:17, Anthony Green <green@redhat.com> wrote:
> "Dr. David Alan Gilbert" <david.gilbert@linaro.org> writes:
>
>>    2) I've tested it on i386 (1659 expected passes, 15 unsupported),
>>                         armel (1654 expected passes, 5 unexpecteed passes (cls_longdouble.c), 15 unsupported)
>>                         armhf (1654 expected passes, 5 unexpecteed passes (cls_longdouble.c), 15 unsupported)
>>                         s390x (1639 expected passes, 5 unexpected failures - err_bad_abi.c)
>>               Those cls_longdouble unexpected passes and err_bad_abi.c
>>               failure are there in the current head.
>>       powerpc64 seems to be broken on current head, but I tested this patch
>>       on powerpc64 on the .0.9 release and it was OK.
>
> I just tested the head on powerpc64-unknown-linux-gnu and had no
> problems.  You appear to be testing powerpc64-unknown-linux-gnu like me,
> but with a different gcc and binutils version.
>
> You wrote on the wiki...
>> Failure is src/powerpc/ffi.c:961 where cif->abi is expected to be
>> FFI_GCC_SYSV or FFI_SYSV but is getting FFI_LINUX
>
> Line 961 is only run when POWERPC64 isn't defined.
>
> POWERPC64 is defined in src/powerpc/ffitarget.h.   Could you please see
> why it's not being defined in your build environment?

It seems to be a 32 v 64 issue. It's got a 64bit kernel but by default
gcc is producing 32bit
binaries, the __powerpc64__ flag is only set if -m64 is passed.
However, config.guess is saying
it's a powerpc64-unknown-linux-gnu - and hence that's the directory
that was created.

So I guess it's actually a failure on powerpc32 not  64.


$ uname -a
Linux daves-g5 2.6.26-2-powerpc64 #1 SMP Thu Nov 25 15:01:22 UTC 2010
ppc64 GNU/Linux
$ cat /etc/issue
Debian GNU/Linux 5.0 \n \l
$ gcc -v
Using built-in specs.
Target: powerpc-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian
4.3.2-1.1' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr
--enable-shared --with-system-zlib --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix --enable-nls
--with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3
--enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc
--enable-mpfr --disable-softfloat --enable-secureplt
--enable-targets=powerpc-linux,powerpc64-linux --with-cpu=default32
--with-long-double-128 --enable-checking=release
--build=powerpc-linux-gnu --host=powerpc-linux-gnu
--target=powerpc-linux-gnu
Thread model: posix
gcc version 4.3.2 (Debian 4.3.2-1.1)

There is the opposite problem that if you pass CFLAGS=-m64 and/or run
with linux64 the make check fails because it doesn't build the tests
64bit:

Executing on host: gcc
/home/dg/libffi-3.0.10rc5/testsuite/libffi.call/closure_fn0.c  -O0 -W
-Wall  -I/home/dg/libffi-3.0.10rc5/powerpc64-unknown-linux-gnu/testsuite/../include
-I/home/dg/libffi-3.0.10rc5/testsuite/../include
-I/home/dg/libffi-3.0.10rc5/powerpc64-unknown-linux-gnu/testsuite/../include/..
-L/home/dg/libffi-3.0.10rc5/powerpc64-unknown-linux-gnu/testsuite/../.libs
 -lffi -lm   -o ./closure_fn0.exe    (timeout = 300)
/usr/bin/ld: skipping incompatible
/home/dg/libffi-3.0.10rc5/powerpc64-unknown-linux-gnu/testsuite/../.libs/libffi.so
when searching for -lffi

(here that libffi.so is 64bi)

Dave

  reply	other threads:[~2011-02-24 10:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 15:41 [PATCH] Add variadic support Dr. David Alan Gilbert
2011-02-23 12:39 ` Anthony Green
2011-02-23 13:12   ` David Gilbert
2011-02-23 13:26     ` Chung-Lin Tang
2011-02-23 16:20       ` David Gilbert
2011-02-23 16:56         ` Chung-Lin Tang
2011-02-23 17:21           ` David Gilbert
2011-02-23 17:39             ` Chung-Lin Tang
2011-02-24  6:37               ` Chung-Lin Tang
2011-02-25 12:56               ` David Gilbert
2011-02-25 13:23                 ` Chung-Lin Tang
2011-02-25 19:02                   ` Anthony Green
2011-02-28  9:08                     ` David Gilbert
2011-03-07 18:19                   ` David Gilbert
2011-03-16  9:52                     ` Chung-Lin Tang
2011-03-16 14:12                       ` Anthony Green
2011-03-16 14:25                         ` David Gilbert
2011-02-23 21:16 ` PowerPC failures (Was: [PATCH] Add variadic support) Anthony Green
2011-02-24 10:43   ` David Gilbert [this message]
2011-02-24 22:37     ` PowerPC failures Anthony Green
2011-02-24 22:41       ` Matthias Klose
2011-02-25 19:18         ` Anthony Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinvwPkFFq11jwrStGNBdsj9k8j527+h0+Da81TC@mail.gmail.com \
    --to=david.gilbert@linaro.org \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=cltang@linaro.org \
    --cc=green@redhat.com \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).