From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30744 invoked by alias); 18 Nov 2011 12:09:03 -0000 Received: (qmail 30733 invoked by uid 22791); 18 Nov 2011 12:09:02 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,TW_BF X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Nov 2011 12:08:49 +0000 Received: by wwp14 with SMTP id 14so3922109wwp.12 for ; Fri, 18 Nov 2011 04:08:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.185.136 with SMTP id u8mr447299wem.89.1321618127790; Fri, 18 Nov 2011 04:08:47 -0800 (PST) Received: by 10.216.37.2 with HTTP; Fri, 18 Nov 2011 04:08:47 -0800 (PST) In-Reply-To: <4EBF4D9E.9020409@moxielogic.com> References: <4EBF4D9E.9020409@moxielogic.com> Date: Fri, 18 Nov 2011 12:09:00 -0000 Message-ID: Subject: Re: libffi 3.0.11 release candidate 2 available for testing From: David Gilbert To: Anthony Green Cc: "libffi-discuss@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2011/txt/msg00214.txt.bz2 On 13 November 2011 04:54, Anthony Green wrote: > I've just uploaded libffi 3.0.11rc2 for testing here: > =A0ftp://sourceware.org/pub/libffi/libffi-3.0.11-rc2.tar.gz > > I bumped the sonumber for 3.0.11 because it contains two ABI changes... > > 1) a debug function was removed from the non-debug builds > > 2) this test release includes David Gilbert's changes to support variadic > functions. Hi Anthony, Thanks for that - but it looks like a small chunk is missing from one of the test cases: On armhf I'm getting: FAIL: libffi.call/cls_double_va.c -O0 -W -Wall output pattern test, is 7.0 res: 4 2.6 res: 4 ? should match 7.0 ?es: 4 ?.0 res: 4 and looking at cls_double_va.c it's missing the chunk: @@ -48,6 +48,10 @@ int main (void) printf("res: %d\n", (int) res); // { dg-output "\nres: 4" } + /* The call to cls_double_va_fn is static, so have to use a normal prep_cif */ + CHECK(ffi_prep_cif(&cif, FFI_DEFAULT_ABI, 2, &ffi_type_sint, + arg_types) =3D=3D FFI_OK); + CHECK(ffi_prep_closure_loc(pcl, &cif, cls_double_va_fn, NULL, code) =3D=3D FFI_OK); res =3D ((int(*)(char*, double))(code))(format, doubleArg); that was in my patch; the failures go away with that. (We also get XPASS: libffi.call/cls_longdouble.c which I think is an old one, just with it not knowing it will work on modern ARM - that's both arm and armhf) Dave (away for the next week)