From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libffi-discuss-return-2165-listarch-libffi-discuss=sources.redhat.com@sourceware.org>
Received: (qmail 8405 invoked by alias); 10 Feb 2015 19:02:49 -0000
Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libffi-discuss.sourceware.org>
List-Subscribe: <mailto:libffi-discuss-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libffi-discuss/>
List-Post: <mailto:libffi-discuss@sourceware.org>
List-Help: <mailto:libffi-discuss-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libffi-discuss-owner@sourceware.org
Received: (qmail 8379 invoked by uid 89); 10 Feb 2015 19:02:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-la0-f51.google.com
Received: from mail-la0-f51.google.com (HELO mail-la0-f51.google.com) (209.85.215.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 Feb 2015 19:02:48 +0000
Received: by labpv20 with SMTP id pv20so8353199lab.8        for <libffi-discuss@sourceware.org>; Tue, 10 Feb 2015 11:02:44 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.112.148.34 with SMTP id tp2mr24285554lbb.94.1423594964646; Tue, 10 Feb 2015 11:02:44 -0800 (PST)
Received: by 10.25.21.213 with HTTP; Tue, 10 Feb 2015 11:02:44 -0800 (PST)
In-Reply-To: <54DA4F85.70606@redhat.com>
References: <CA+=Sn1m6s93Gvuv7OvCGciYfbLWdmQYkqm8m7ruQn7DL2pXZ3w@mail.gmail.com>	<54DA4F85.70606@redhat.com>
Date: Tue, 10 Feb 2015 19:02:00 -0000
Message-ID: <CA+=Sn1=Urso0f5c_3KUH5OnwPTJO2ir6qaGkncTB+eroqBZidQ@mail.gmail.com>
Subject: Re: [PATCH] Implement libffi for AARCH64:ILP32
From: Andrew Pinski <pinskia@gmail.com>
To: Richard Henderson <rth@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, 	"libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015/txt/msg00032.txt.bz2

On Tue, Feb 10, 2015 at 10:35 AM, Richard Henderson <rth@redhat.com> wrote:
> On 02/09/2015 12:40 AM, Andrew Pinski wrote:
>>  #ifndef LIBFFI_ASM
>> +#ifdef __ILP32__
>> +typedef unsigned long long ffi_arg;
>> +typedef signed long long ffi_sarg;
>> +#else
>
> You need to set FFI_SIZEOF_ARG too.
>
> Otherwise it looks ok.

Thanks.  I am testing the patch with the following added under the ILP32 check:
+#define FFI_SIZEOF_ARG 8
+#define FFI_SIZEOF_JAVA_RAW  4


Thanks,
Andrew Pinski


>
>
> r~