From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5962 invoked by alias); 10 Feb 2015 22:46:42 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 5937 invoked by uid 89); 10 Feb 2015 22:46:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f43.google.com Received: from mail-la0-f43.google.com (HELO mail-la0-f43.google.com) (209.85.215.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 Feb 2015 22:46:40 +0000 Received: by lams18 with SMTP id s18so17560485lam.11 for ; Tue, 10 Feb 2015 14:46:37 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.5.6 with SMTP id o6mr8634494lao.59.1423608397462; Tue, 10 Feb 2015 14:46:37 -0800 (PST) Received: by 10.25.21.213 with HTTP; Tue, 10 Feb 2015 14:46:37 -0800 (PST) In-Reply-To: <54DA7604.8020807@redhat.com> References: <54DA4F85.70606@redhat.com> <54DA7604.8020807@redhat.com> Date: Tue, 10 Feb 2015 22:46:00 -0000 Message-ID: Subject: Re: [PATCH] Implement libffi for AARCH64:ILP32 From: Andrew Pinski To: Richard Henderson Cc: GCC Patches , "libffi-discuss@sourceware.org" Content-Type: multipart/mixed; boundary=089e01419d1ad49bb5050ec3a8ee X-SW-Source: 2015/txt/msg00034.txt.bz2 --089e01419d1ad49bb5050ec3a8ee Content-Type: text/plain; charset=UTF-8 Content-length: 810 On Tue, Feb 10, 2015 at 1:20 PM, Richard Henderson wrote: > On 02/10/2015 11:02 AM, Andrew Pinski wrote: >> +#define FFI_SIZEOF_JAVA_RAW 4 > > Since aarch64 doesn't implement the raw java api, this is irrelevant. Ok. This is what I applied to GCC after testing it (I don't have access to the libffi git repo). 2015-02-10 Andrew Pinski * src/aarch64/ffitarget.h (ffi_arg): Use unsigned long long for ILP32. (FFI_SIZEOF_ARG): Define to 64 for ILP32. (ffi_sarg): Use signed long long for ILP32. * src/aarch64/sysv.S (PTR_REG): New macro. (PTR_SIZE): New macro. (ffi_closure_SYSV): Load cif, fn and user_data using PTR_REG. (ffi_go_closure_SYSV): Load cif and fn using PTR_REG. Thanks, Andrew Pinski > > > r~ --089e01419d1ad49bb5050ec3a8ee Content-Type: text/plain; charset=US-ASCII; name="fixlibffi.diff.txt" Content-Disposition: attachment; filename="fixlibffi.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i5zvna6c0 Content-length: 3205 Y29tbWl0IGIzZDRkZjczMDRkY2JjNTY0NzVmNDAwODM3YjQ3ZmM1MjE0MzI5 MmUKQXV0aG9yOiBBbmRyZXcgUGluc2tpIDxhcGluc2tpQGNhdml1bS5jb20+ CkRhdGU6ICAgTW9uIEZlYiA5IDA4OjQxOjA5IDIwMTUgKzAwMDAKCiAgICAq IHNyYy9hYXJjaDY0L2ZmaXRhcmdldC5oIChmZmlfYXJnKTogVXNlIHVuc2ln bmVkIGxvbmcgbG9uZyBmb3IgSUxQMzIuCiAgICAoRkZJX1NJWkVPRl9BUkcp OiBEZWZpbmUgdG8gNjQgZm9yIElMUDMyLgogICAgKGZmaV9zYXJnKTogVXNl IHNpZ25lZCBsb25nIGxvbmcgZm9yIElMUDMyLgogICAgCiAgICAqIHNyYy9h YXJjaDY0L3N5c3YuUyAoUFRSX1JFRyk6IE5ldyBtYWNyby4KICAgIChQVFJf U0laRSk6IE5ldyBtYWNyby4KICAgIChmZmlfY2xvc3VyZV9TWVNWKTogTG9h ZCBjaWYsIGZuIGFuZCB1c2VyX2RhdGEgdXNpbmcgUFRSX1JFRy4KICAgIChm ZmlfZ29fY2xvc3VyZV9TWVNWKTogTG9hZCBjaWYgYW5kIGZuIHVzaW5nIFBU Ul9SRUcuCgpkaWZmIC0tZ2l0IGEvbGliZmZpL3NyYy9hYXJjaDY0L2ZmaXRh cmdldC5oIGIvbGliZmZpL3NyYy9hYXJjaDY0L2ZmaXRhcmdldC5oCmluZGV4 IGZjYTI4MTEuLjI4NjJlYzcgMTAwNjQ0Ci0tLSBhL2xpYmZmaS9zcmMvYWFy Y2g2NC9mZml0YXJnZXQuaAorKysgYi9saWJmZmkvc3JjL2FhcmNoNjQvZmZp dGFyZ2V0LmgKQEAgLTI3LDggKzI3LDE0IEBAIFNPRlRXQVJFIE9SIFRIRSBV U0UgT1IgT1RIRVIgREVBTElOR1MgSU4gVEhFIFNPRlRXQVJFLiAgKi8KICNl bmRpZgogCiAjaWZuZGVmIExJQkZGSV9BU00KKyNpZmRlZiBfX0lMUDMyX18K KyNkZWZpbmUgRkZJX1NJWkVPRl9BUkcgOAordHlwZWRlZiB1bnNpZ25lZCBs b25nIGxvbmcgZmZpX2FyZzsKK3R5cGVkZWYgc2lnbmVkIGxvbmcgbG9uZyBm Zmlfc2FyZzsKKyNlbHNlCiB0eXBlZGVmIHVuc2lnbmVkIGxvbmcgZmZpX2Fy ZzsKIHR5cGVkZWYgc2lnbmVkIGxvbmcgZmZpX3Nhcmc7CisjZW5kaWYKIAog dHlwZWRlZiBlbnVtIGZmaV9hYmkKICAgewpkaWZmIC0tZ2l0IGEvbGliZmZp L3NyYy9hYXJjaDY0L3N5c3YuUyBiL2xpYmZmaS9zcmMvYWFyY2g2NC9zeXN2 LlMKaW5kZXggNDZmNTBiOS4uYzFiZjliOSAxMDA2NDQKLS0tIGEvbGliZmZp L3NyYy9hYXJjaDY0L3N5c3YuUworKysgYi9saWJmZmkvc3JjL2FhcmNoNjQv c3lzdi5TCkBAIC00NSw2ICs0NSwxOCBAQCBTT0ZUV0FSRSBPUiBUSEUgVVNF IE9SIE9USEVSIERFQUxJTkdTIElOIFRIRSBTT0ZUV0FSRS4gICovCiAjIGRl ZmluZSBCRShYKQkwCiAjZW5kaWYKIAorI2lmZGVmIF9fSUxQMzJfXworI2Rl ZmluZSBQVFJfUkVHKG4pICAgICAgdyMjbgorI2Vsc2UKKyNkZWZpbmUgUFRS X1JFRyhuKSAgICAgIHgjI24KKyNlbmRpZgorCisjaWZkZWYgX19JTFAzMl9f CisjZGVmaW5lIFBUUl9TSVpFCTQKKyNlbHNlCisjZGVmaW5lIFBUUl9TSVpF CTgKKyNlbmRpZgorCiAJLnRleHQKIAkuYWxpZ24gNAogCkBAIC0yNDgsOCAr MjYwLDggQEAgQ05BTUUoZmZpX2Nsb3N1cmVfU1lTVik6CiAJc3RwICAgICB4 NiwgeDcsIFtzcCwgIzE2ICsgMTYqTl9WX0FSR19SRUcgKyA0OF0KIAogCS8q IExvYWQgZmZpX2Nsb3N1cmVfaW5uZXIgYXJndW1lbnRzLiAgKi8KLQlsZHAJ eDAsIHgxLCBbeDE3LCAjRkZJX1RSQU1QT0xJTkVfQ0xPU1VSRV9PRkZTRVRd CS8qIGxvYWQgY2lmLCBmbiAqLwotCWxkcgl4MiwgW3gxNywgI0ZGSV9UUkFN UE9MSU5FX0NMT1NVUkVfT0ZGU0VUKzE2XQkvKiBsb2FkIHVzZXJfZGF0YSAq LworCWxkcAlQVFJfUkVHKDApLCBQVFJfUkVHKDEpLCBbeDE3LCAjRkZJX1RS QU1QT0xJTkVfQ0xPU1VSRV9PRkZTRVRdCS8qIGxvYWQgY2lmLCBmbiAqLwor CWxkcglQVFJfUkVHKDIpLCBbeDE3LCAjRkZJX1RSQU1QT0xJTkVfQ0xPU1VS RV9PRkZTRVQrUFRSX1NJWkUqMl0JLyogbG9hZCB1c2VyX2RhdGEgKi8KIC5M ZG9fY2xvc3VyZToKIAlhZGQJeDMsIHNwLCAjMTYJCQkJLyogbG9hZCBjb250 ZXh0ICovCiAJYWRkCXg0LCBzcCwgI2ZmaV9jbG9zdXJlX1NZU1ZfRlMJCS8q IGxvYWQgc3RhY2sgKi8KQEAgLTQwMyw3ICs0MTUsNyBAQCBDTkFNRShmZmlf Z29fY2xvc3VyZV9TWVNWKToKIAlzdHAgICAgIHg2LCB4NywgW3NwLCAjMTYg KyAxNipOX1ZfQVJHX1JFRyArIDQ4XQogCiAJLyogTG9hZCBmZmlfY2xvc3Vy ZV9pbm5lciBhcmd1bWVudHMuICAqLwotCWxkcAl4MCwgeDEsIFt4MTgsICM4 XQkJCS8qIGxvYWQgY2lmLCBmbiAqLworCWxkcAlQVFJfUkVHKDApLCBQVFJf UkVHKDEpLCBbeDE4LCAjUFRSX1NJWkVdLyogbG9hZCBjaWYsIGZuICovCiAJ bW92CXgyLCB4MTgJCQkJCS8qIGxvYWQgdXNlcl9kYXRhICovCiAJYgkuTGRv X2Nsb3N1cmUKIAljZmlfZW5kcHJvYwo= --089e01419d1ad49bb5050ec3a8ee--