public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix dejagnu test support for --tool_opts
@ 2016-02-03 21:39 Filipe Brandenburger
  2016-02-09 22:17 ` Filipe Brandenburger
  0 siblings, 1 reply; 2+ messages in thread
From: Filipe Brandenburger @ 2016-02-03 21:39 UTC (permalink / raw)
  To: libffi-discuss; +Cc: Filipe Brandenburger

Right now it concatenates it with the existing options and then appends
it to that list, fix it to simply append it as is, same as it is done
with the other variables.

Tested by running the following command which includes gcc options:
  $ make check RUNTESTFLAGS="--tool_opts '-Werror'"

Without this patch, all the tests fail. With it, the test succeed.
Inspecting the logs shows that -Werror was indeed used when compiling
the test sources.
---
Also available as a GitHub PR:
https://github.com/atgreen/libffi/pull/205

Re-sending it to this mailing list, in case GitHub PRs are not the best way to
push this, and e-mail submissions are preferred.

Thanks!
Filipe

 testsuite/lib/libffi.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/lib/libffi.exp b/testsuite/lib/libffi.exp
index 1b8b008fe297..0d74627207dc 100644
--- a/testsuite/lib/libffi.exp
+++ b/testsuite/lib/libffi.exp
@@ -182,7 +182,7 @@ proc libffi_target_compile { source dest type options } {
     # TOOL_OPTIONS must come first, so that it doesn't override testcase
     # specific options.
     if [info exists TOOL_OPTIONS] {
-	lappend  options [concat "additional_flags=$TOOL_OPTIONS" $options];
+	lappend  options "additional_flags=$TOOL_OPTIONS"
     }
 
     # search for ffi_mips.h in srcdir, too
-- 
2.7.0.rc3.207.g0ac5344

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix dejagnu test support for --tool_opts
  2016-02-03 21:39 [PATCH] Fix dejagnu test support for --tool_opts Filipe Brandenburger
@ 2016-02-09 22:17 ` Filipe Brandenburger
  0 siblings, 0 replies; 2+ messages in thread
From: Filipe Brandenburger @ 2016-02-09 22:17 UTC (permalink / raw)
  To: libffi-discuss

On Wed, Feb 3, 2016 at 1:39 PM, Filipe Brandenburger
<filbranden@google.com> wrote:
> Right now it concatenates it with the existing options and then appends
> it to that list, fix it to simply append it as is, same as it is done
> with the other variables.
>
> Tested by running the following command which includes gcc options:
>   $ make check RUNTESTFLAGS="--tool_opts '-Werror'"
>
> Without this patch, all the tests fail. With it, the test succeed.
> Inspecting the logs shows that -Werror was indeed used when compiling
> the test sources.
> ---
> Also available as a GitHub PR:
> https://github.com/atgreen/libffi/pull/205
>
> Re-sending it to this mailing list, in case GitHub PRs are not the best way to
> push this, and e-mail submissions are preferred.

Ping?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-09 22:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03 21:39 [PATCH] Fix dejagnu test support for --tool_opts Filipe Brandenburger
2016-02-09 22:17 ` Filipe Brandenburger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).