From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78903 invoked by alias); 9 Feb 2016 22:17:33 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 78891 invoked by uid 89); 9 Feb 2016 22:17:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:824, preferred, HTo:U*libffi-discuss X-HELO: mail-vk0-f42.google.com Received: from mail-vk0-f42.google.com (HELO mail-vk0-f42.google.com) (209.85.213.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 09 Feb 2016 22:17:32 +0000 Received: by mail-vk0-f42.google.com with SMTP id e6so941067vkh.2 for ; Tue, 09 Feb 2016 14:17:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=zQmpvtQNGpXVOUuHUM0iv762f/999+Pvc37hVyQY1n8=; b=hZiOir9jMEG49bZ7YISdF0fhyez4Aoj5zGUQpwV+6LouLn7tUXC2K5TP++YbpLIaPa Yeb6CsEPIfJOrBfGel8y+5Tee93fTbmNLo8Bdon+TNS2zGWUVSs5jXqDdwSjwQSaMh6y hp/J9PQc5e8dFBaQpjwUxxXgWYsX/I/ZYhma23za7KjSHcnIb6oJcBb5zIyXb+lCj10A XNtJZkd0yaDn8/AaewH9qB5S/KUaet+D+eJMgDLzNQvJY3VKNB6JSrn1McdGXRfxidXe YZQclL+SZykq8FP5LPH7WMTwLGr27ROnump5WoRobQtLmusrsE+IMkR3YJkXSmhl7abp pJyg== X-Gm-Message-State: AG10YOT+UIaL3IyclImciVJfBpJNWeCJgWe4IvKBWHIKp2EVDm7NWk6uhFzuCtaDkhy8KiOAO9No4kWFEPIP+hHM MIME-Version: 1.0 X-Received: by 10.31.8.83 with SMTP id 80mr27539257vki.105.1455056249755; Tue, 09 Feb 2016 14:17:29 -0800 (PST) Received: by 10.31.233.7 with HTTP; Tue, 9 Feb 2016 14:17:29 -0800 (PST) In-Reply-To: <1454535567-9589-1-git-send-email-filbranden@google.com> References: <1454535567-9589-1-git-send-email-filbranden@google.com> Date: Tue, 09 Feb 2016 22:17:00 -0000 Message-ID: Subject: Re: [PATCH] Fix dejagnu test support for --tool_opts From: Filipe Brandenburger To: libffi-discuss@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016/txt/msg00007.txt.bz2 On Wed, Feb 3, 2016 at 1:39 PM, Filipe Brandenburger wrote: > Right now it concatenates it with the existing options and then appends > it to that list, fix it to simply append it as is, same as it is done > with the other variables. > > Tested by running the following command which includes gcc options: > $ make check RUNTESTFLAGS="--tool_opts '-Werror'" > > Without this patch, all the tests fail. With it, the test succeed. > Inspecting the logs shows that -Werror was indeed used when compiling > the test sources. > --- > Also available as a GitHub PR: > https://github.com/atgreen/libffi/pull/205 > > Re-sending it to this mailing list, in case GitHub PRs are not the best way to > push this, and e-mail submissions are preferred. Ping?