From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5883 invoked by alias); 24 Apr 2014 12:47:26 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 5868 invoked by uid 89); 24 Apr 2014 12:47:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f181.google.com Received: from mail-ve0-f181.google.com (HELO mail-ve0-f181.google.com) (209.85.128.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Apr 2014 12:47:25 +0000 Received: by mail-ve0-f181.google.com with SMTP id oy12so2762385veb.40 for ; Thu, 24 Apr 2014 05:47:23 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.58.187.78 with SMTP id fq14mr1089400vec.9.1398343642934; Thu, 24 Apr 2014 05:47:22 -0700 (PDT) Received: by 10.52.78.194 with HTTP; Thu, 24 Apr 2014 05:47:22 -0700 (PDT) In-Reply-To: <8761my8bz1.fsf@moxielogic.com> References: <87eh2liiow.fsf@moxielogic.com> <87a9ce3ry7.fsf@moxielogic.com> <20140328150533.GA31475@arm.com> <8761my8bz1.fsf@moxielogic.com> Date: Thu, 24 Apr 2014 12:47:00 -0000 Message-ID: Subject: Re: libffi 3.1-rc1 needs testing! From: Marcus Shawcroft To: Anthony Green Cc: James Greenhalgh , "libffi-discuss@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00053.txt.bz2 On 28 March 2014 17:33, Anthony Green wrote: > James Greenhalgh writes: > >> Hi, >> >> I'm seeing issues with libffi.call/float2.c on GCC 4.9 toolchains across >> ARM, AArch64, x86_64. I guess GCC 4.9 is more aggressive in warning for >> unused values: > > Thanks James. I just committed a fix for this. > > AG >> FAIL: libffi.call/float2.c -W -Wall -O0 (test for excess errors) >> FAIL: libffi.call/float2.c -W -Wall -O2 (test for excess errors) >> FAIL: libffi.call/float2.c -W -Wall -O3 (test for excess errors) >> FAIL: libffi.call/float2.c -W -Wall -Os (test for excess errors) >> FAIL: libffi.call/float2.c -W -Wall -O2 -fomit-frame-pointer (test for excess errors) >> >> In file included from ../../testsuite/libffi.call/float2.c:10:0: >> ../../testsuite/libffi.call/float2.c: In function 'main': >> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value] >> #define CHECK(x) (!(x) ? (abort(), 1) : 0) >> ^ >> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK' >> CHECK(0); >> ^ >> output is: >> In file included from ../../testsuite/libffi.call/float2.c:10:0: >> ../../testsuite/libffi.call/float2.c: In function 'main': >> ../../testsuite/libffi.call/ffitest.h:18:39: warning: right-hand operand of comma expression has no effect [-Wunused-value] >> #define CHECK(x) (!(x) ? (abort(), 1) : 0) >> ^ >> ../../testsuite/libffi.call/float2.c:55:5: note: in expansion of macro 'CHECK' >> CHECK(0); >> ^ Hi Anthony, I'm still seeing these failures on master. I'm currently looking at version: commit 31e0d4ecff6dc2a6c75a066ee099b52a43f6ba27 Merge: 1c0e9a7 99909eb Author: Anthony Green Date: Wed Apr 23 19:24:47 2014 -0400 did the fix you applied make it to master? Cheers /Marcus