From: David Edelsohn <dje.gcc@gmail.com>
To: libffi-discuss@sourceware.org,
Peter Bergner <bergner@vnet.ibm.com>,
Anthony Green <green@moxielogic.com>,
kyle@moffetthome.net, dclarke@blastwave.org
Subject: Re: libffi fails to build on powerpc64-linux
Date: Fri, 09 Mar 2012 02:37:00 -0000 [thread overview]
Message-ID: <CAGWvnymH5bPtWJ1eBWL5HUtron39g4fuc==Yp75z_ErVREtaTw@mail.gmail.com> (raw)
> On Tue, 2012-03-06 at 09:34 -0600, Peter Bergner wrote:
> > On Mon, 2012-03-05 at 22:18 -0500, Anthony Green wrote:
> > > At this point, I'm hoping that Kyle Moffett, the author of this patch
> > > can have a look. My guess is that either I mis-applied the patch, or
> > > he posted the wrong patch to apply.
> >
> > Agreed, it would be nice for Kyle to comment. Looking at the bugzilla
> > above, he said:
> >
> > > This passes the testsuite on soft-floating-point PowerPC, and it builds
> > > and passes the testsuite on PowerPC e500 systems which cannot even
> > > assemble the regular floating-point instruction set.
> >
> > Both of these are non FP power systems, so I can see why he didn't
> > see these build errors, since the broken code is inside of
> > "#ifndef __NO_FPRS__" (double negative?).
>
> Looking at the bugzilla further, I noticed Kyle has a blog here that
> mentions he has moved to Google, so that explains why his email address
> was bouncing. I'm also guessing he's no longer interested in PowerPC
> issues now that he's no longer at Boeing.
>
> That said, looking farther down that debian bugzilla, I noticed someone
> complained about his patch breaking the debian build. He attached a
> patch:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=40;filename=libffi-powerpc-build-fix.patch;att=1;bug=644338
>
> If you ignore the debian specific changes and look at the src/powerpc/ffi.c
> change, you'll see it's the same as my patch, minus the hunks of my patch
> that are silencing warnings, so I think my patch is probably safe to take
> as is. Therefore, I'm officially submitting the patch below to fix the
> build issues.
>
> That still leaves the 32-bit many.c testsuite breakage I am seeing, but I
> think that should be fixed in a separate patch since it is not related to
> these changes at all.
>
> Peter
Adding a different email address for Kyle to possibly entice him to
participate in this email thread.
- David
next reply other threads:[~2012-03-09 2:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 2:37 David Edelsohn [this message]
2012-03-09 8:02 ` Kyle Moffett
-- strict thread matches above, loose matches on Subject: below --
2012-03-07 4:13 Dennis Clarke
2012-03-06 4:21 Dennis Clarke
2012-03-06 16:17 ` Peter Bergner
2012-03-05 23:05 Dennis Clarke
2012-03-05 23:29 ` Peter Bergner
2012-03-06 0:29 ` Peter Bergner
2012-03-06 3:18 ` Anthony Green
2012-03-06 15:36 ` Peter Bergner
2012-03-06 16:16 ` Peter Bergner
2012-03-07 4:03 ` Peter Bergner
2012-03-08 23:14 ` Peter Bergner
2012-03-09 1:01 ` Peter Bergner
2012-03-05 22:56 Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnymH5bPtWJ1eBWL5HUtron39g4fuc==Yp75z_ErVREtaTw@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=bergner@vnet.ibm.com \
--cc=dclarke@blastwave.org \
--cc=green@moxielogic.com \
--cc=kyle@moffetthome.net \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).