From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19700 invoked by alias); 24 Jun 2013 02:32:47 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 19680 invoked by uid 89); 24 Jun 2013 02:32:47 -0000 X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_BF autolearn=unavailable version=3.3.1 Received: from mail-vc0-f178.google.com (HELO mail-vc0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 02:32:46 +0000 Received: by mail-vc0-f178.google.com with SMTP id m17so250503vca.23 for ; Sun, 23 Jun 2013 19:32:44 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.52.68.212 with SMTP id y20mr8889506vdt.15.1372041164635; Sun, 23 Jun 2013 19:32:44 -0700 (PDT) Received: by 10.220.118.135 with HTTP; Sun, 23 Jun 2013 19:32:44 -0700 (PDT) In-Reply-To: <20130624002616.GG21523@bubble.grove.modra.org> References: <20130607013408.GI6878@bubble.grove.modra.org> <20130624002616.GG21523@bubble.grove.modra.org> Date: Mon, 24 Jun 2013 02:32:00 -0000 Message-ID: Subject: Re: [RS6000] libffi little-endian From: David Edelsohn To: GCC Patches , libffi-discuss@sourceware.org, Alan Modra Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013/txt/msg00146.txt.bz2 On Sun, Jun 23, 2013 at 8:26 PM, Alan Modra wrote: > On Fri, Jun 07, 2013 at 12:12:17AM -0400, David Edelsohn wrote: >> On Thu, Jun 6, 2013 at 9:34 PM, Alan Modra wrote: >> > Bootstrapped and regression tested powerpc64-linux. OK to apply? >> > >> > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Support >> > little-endian. >> > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise. >> >> This patch needs to be applied upstream in the libffi repository. >> >> All of the handling of structs in ffi.c and ffi_darwin.c doesn't need >> any changes? Cool. I thought there might be a padding issue. > > You were right, of course. When we finally got around to running an > all languages bootstrap on powerpc64le, we discovered some missing > pieces in libffi. The following adds some ffi.c changes to the > previous patch (closure.S patches are unchanged). I haven't tackled > ffi_darwin.c. > > Bootstrapped and regression tested powerpc64-linux. This one passes > the libffi testsuite on powerpc64le-linux. OK mainline and 4.8? > > * src/powerpc/ffi.c (ffi_prep_args_SYSV): Move var declaration > before statements. > (ffi_prep_args64): Support little-endian. > (ffi_closure_helper_SYSV, ffi_closure_helper_LINUX64): Likewise. > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Likewise. > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise. This looks okay to me and more like the changes I expected. Assuming Anthony accepts it upstream. Thanks, David