public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Chi-Hsuan Yen <yan12125@gmail.com>
To: Anthony Green <green@moxielogic.com>
Cc: "libffi-discuss@sourceware.org" <libffi-discuss@sourceware.org>
Subject: Re: Install public headers in the standard path?
Date: Fri, 06 Jan 2017 15:16:00 -0000	[thread overview]
Message-ID: <CAMNjDR2MCWBcFn8Vm8odvORvArJOE1iNwq8XWDk+9p02-5bNZA@mail.gmail.com> (raw)
In-Reply-To: <CACxje5-8Qs7BPSXqJUH+mF2kAvOnNg-ViwdNudJAFP2P3e4awA@mail.gmail.com>

On 6 January 2017 at 07:53, Anthony Green <green@moxielogic.com> wrote:
> Thanks for your patch.
>
> If you can believe it, installing certain headers under /usr/lib was a
> thing back in the mid/late 90s (gnome, or gtk, or similar did this as
> well).  libffi headers are modified at configure time, and the
> thinking back then was that the contents of /usr/include should not
> vary based on configuration changes (or even on per-host basis).
> Also, using pkg-config made it easy to install multiple versions of
> libffi as the ABI hadn't settled down yet.
>

Thanks for clarification. The original decision looks much reasonable now!

> A few years ago I sat down to rewrite the headers to depend solely on
> compiler-defined macros, but got lost in the maze of Power
> alternatives.  Every other port was fairly straight forward - but
> Power was a mess.
>
> I'm OK with moving the headers to /usr/include now, although it would
> have been nice to remove the configure-time dependencies from them
> first.
>

Did you mean eliminating the process of ffi.h.in -> ffi.h? I guess it
can be resolved by distributing fficonfig.h as well. Lots of
autotools-based projects do similar. For example, CPython distributes
/usr/include/python3.6m/pyconfig.h.

> AG
>
>
>
> On Tue, Nov 15, 2016 at 7:10 AM, Chi-Hsuan Yen <yan12125@gmail.com> wrote:
>> Hello libffi enthusiasts,
>>
>> Currently libffi public headers are installed in
>> $PREFIX/lib/libffi-3.x.y/include. The only reliable approach to get
>> the include path is via pkg-config. There are some disadvantages:
>>
>> 1. pkg-config is tricky in terms of cross-compilation. To cross-build
>> libffi clients, PKG_CONFIG_LIBDIR, PKG_CONFIG_SYSROOT_DIR,
>> PKG_CONFIG_ALLOW_SYSTEM_{CFLAGS,LIBS} may be involved to make it
>> working
>>
>> 2. pkg-config does not come with macOS. Recently CPython is seeking
>> for chances to drop bundled libffi copy. [1] However, CPython core
>> developers are against including additional tools other than
>> XCode/Command Line Tools in CPython build time requirements
>>
>> There are some more discussions here:
>> https://github.com/libffi/libffi/issues/258
>>
>> As a result, I suggest to move header files to conventional
>> $PREFIX/include, so that libffi clients can have simpler build
>> systems.
>>
>> Here's my implementation: https://github.com/libffi/libffi/pull/288
>>
>> Any ideas?
>>
>> Best,
>>
>> Yen, Chi-Hsuan
>>
>> [1] http://bugs.python.org/issue28491

      reply	other threads:[~2017-01-06 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 12:10 Chi-Hsuan Yen
2017-01-05 23:53 ` Anthony Green
2017-01-06 15:16   ` Chi-Hsuan Yen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMNjDR2MCWBcFn8Vm8odvORvArJOE1iNwq8XWDk+9p02-5bNZA@mail.gmail.com \
    --to=yan12125@gmail.com \
    --cc=green@moxielogic.com \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).