From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5683 invoked by alias); 12 Jan 2015 23:46:33 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 5661 invoked by uid 89); 12 Jan 2015 23:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f178.google.com Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 12 Jan 2015 23:46:30 +0000 Received: by mail-ob0-f178.google.com with SMTP id gq1so25022276obb.9 for ; Mon, 12 Jan 2015 15:46:28 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.202.174.198 with SMTP id x189mr17938867oie.78.1421106388690; Mon, 12 Jan 2015 15:46:28 -0800 (PST) Received: by 10.76.185.7 with HTTP; Mon, 12 Jan 2015 15:46:28 -0800 (PST) In-Reply-To: References: Date: Mon, 12 Jan 2015 23:46:00 -0000 Message-ID: Subject: Re: libffi is broken for x32 From: "H.J. Lu" To: Anthony Green , GCC Patches , libffi-discuss@sourceware.org Content-Type: multipart/mixed; boundary=001a113ce8e47cdee0050c7d1d26 X-SW-Source: 2015/txt/msg00010.txt.bz2 --001a113ce8e47cdee0050c7d1d26 Content-Type: text/plain; charset=UTF-8 Content-length: 606 On Mon, Jan 12, 2015 at 2:42 PM, H.J. Lu wrote: > This libffi commit: > > 13e2d7b92557a9511a0414df82bf2df3edc55cba is the first bad commit > commit 13e2d7b92557a9511a0414df82bf2df3edc55cba > Author: Anthony Green > Date: Thu Jan 10 10:52:02 2013 -0500 > > Handle both 32 and 64-bit x86 builds regardless of target triple > > breaks x32. > This patch passed "make check" in libffi on x32. I am testing it in GCC now. GCC is configured as x86_64-unknown-linux-gnu with x32 enabled. libffi should set TARGET to X86_64 if __x86_64__ is defined. -- H.J. --001a113ce8e47cdee0050c7d1d26 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Set-TARGET-to-X86_64-if-__x86_64__-is-defined.patch" Content-Disposition: attachment; filename="0001-Set-TARGET-to-X86_64-if-__x86_64__-is-defined.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4uhyuna0 Content-length: 1066 RnJvbSA5YWVkYWU1ODQ4MzMzYWNmNTVmYTM0ZmQ3MzRkNTcwNDM2NGNjYWEx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IE1vbiwgMTIgSmFuIDIwMTUgMTU6 MjU6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBTZXQgVEFSR0VUIHRvIFg4 Nl82NCBpZiBfX3g4Nl82NF9fIGlzIGRlZmluZWQKCi0tLQogY29uZmlndXJl Lmhvc3QgfCA4ICsrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvY29uZmlndXJl Lmhvc3QgYi9jb25maWd1cmUuaG9zdAppbmRleCA1ZWU2MzJjLi5jN2ViOWM4 IDEwMDY0NAotLS0gYS9jb25maWd1cmUuaG9zdAorKysgYi9jb25maWd1cmUu aG9zdApAQCAtMTAwLDcgKzEwMCwxMyBAQCBjYXNlICIke2hvc3R9IiBpbgog CSAgICAgIFRBUkdFVD1YODZfNjQKIAkgICAgICA7OwogCSAgICAqKQotCSAg ICAgIFRBUkdFVD1YODYKKwkgICAgICBlY2hvICdpbnQgZm9vICh2b2lkKSB7 IHJldHVybiBfX3g4Nl82NF9fOyB9JyA+IGNvbmZ0ZXN0LmMKKwkgICAgICBp ZiAkQ0MgJENGTEFHUyAtV2Vycm9yIC1TIGNvbmZ0ZXN0LmMgLW8gY29uZnRl c3QucyA+IC9kZXYvbnVsbCAyPiYxOyB0aGVuCisJCVRBUkdFVD1YODZfNjQ7 CisJICAgICAgZWxzZQorCQlUQVJHRVQ9WDg2OworCSAgICAgIGZpCisJICAg ICAgcm0gLWYgY29uZnRlc3QuKgogCSAgICAgIDs7CiAgICAgICAgICAgZXNh YwogCWVsc2UKLS0gCjEuOS4zCgo= --001a113ce8e47cdee0050c7d1d26--