From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70877 invoked by alias); 11 Nov 2019 23:29:33 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 70853 invoked by uid 89); 11 Nov 2019 23:29:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.208.67, H*RU:209.85.208.67, HX-HELO:sk:mail-ed, H*r:sk:mail-ed X-HELO: mail-ed1-f67.google.com Received: from mail-ed1-f67.google.com (HELO mail-ed1-f67.google.com) (209.85.208.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Nov 2019 23:29:32 +0000 Received: by mail-ed1-f67.google.com with SMTP id a67so13341275edf.11 for ; Mon, 11 Nov 2019 15:29:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X0w4qiU/ShLXt8YsHgxfSvugh9gXQU2pNbKCg+Anzq8=; b=bJ9BzNqBJojzCYq6NntqgDwjiG3kkv7fYqXD3GFqybhZtMd6yfpa7+9LcTx7Ch+w5X qpd+Onvth7O6NfeJ5RUL9px7/05clR1VVYwoulLIuVnsDqqvu3y61LReLLwLjtKeLolm WK9d2Njb4lQWxWsj4Hm/JJmy0PY1TntRu9o27kMDYX4XJUtlMP3OkHIx+xucLWlp/Drg WmRDyOhz8bbptFpiXHvK4GhrySFDr7ypDHhNQ5lHjFratR8lecr7pe/LSmVUzy8YBtuY qEvkemEEZTuWdib7ZptEvh4jBDQwZJjCZS3337j52QtEBZrzGXfuR5QXwdokIQp5WkHo LJBQ== MIME-Version: 1.0 References: In-Reply-To: From: Ian Lance Taylor Date: Mon, 11 Nov 2019 23:29:00 -0000 Message-ID: Subject: Re: [golang-dev] [PATCH 3/4] libgo/test: Fix compilation for build sysroot To: "Maciej W. Rozycki" Cc: gcc-patches , libffi-discuss@sourceware.org, golang-dev Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019/txt/msg00078.txt.bz2 On Mon, Nov 11, 2019 at 10:12 AM Maciej W. Rozycki wrote: > > Fix a problem with the libgo testsuite using a method to determine the > compiler to use resulting in the tool being different from one the > library has been built with, and causing a catastrophic failure from the > lack of a suitable `--sysroot=' option where the `--with-build-sysroot=' > configuration option has been used to build the compiler resulting in > the inability to link executables. > > Address this problem by providing a DejaGNU configuration file defining > the compiler to use, via the GOC_UNDER_TEST TCL variable, set from $GOC > by autoconf, which will have all the required options set for the target > compiler to build executables in the environment configured, removing > failures like: > > .../bin/riscv64-linux-gnu-ld: cannot find crt1.o: No such file or directory > .../bin/riscv64-linux-gnu-ld: cannot find -lm > .../bin/riscv64-linux-gnu-ld: cannot find -lc > collect2: error: ld returned 1 exit status > compiler exited with status 1 > > No summary comparison, because the libgo testsuite does not provide one > in this configuration for some reason, however this change improves > overall test results for the `riscv64-linux-gnu' target (here with the > `x86_64-linux-gnu' host and RISC-V QEMU in the Linux user emulation mode > as the target board) from 0 PASSes and 159 FAILs to 133 PASSes and 26 > FAILs. > > libgo/ > * configure.ac: Add testsuite/libgo-test-support.exp to output > files. > * configure: Regenerate. > * testsuite/libgo-test-support.exp.in: New file. > * testsuite/Makefile.am (EXTRA_DEJAGNU_SITE_CONFIG): New > variable. > * testsuite/Makefile.in: Regenerate. > * testsuite/lib/libgo.exp: Don't override GOC_UNDER_TEST > previously set. Thanks. Committed to mainline. Ian