From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10735 invoked by alias); 1 Mar 2012 13:40:42 -0000 Received: (qmail 10634 invoked by uid 22791); 1 Mar 2012 13:40:41 -0000 X-SWARE-Spam-Status: No, hits=3.8 required=5.0 tests=AWL,BAYES_00,BOTNET,RCVD_IN_DNSWL_NONE,TW_BF X-Spam-Check-By: sourceware.org Received: from vms173015pub.verizon.net (HELO vms173015pub.verizon.net) (206.46.173.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 13:40:23 +0000 Received: from [172.16.0.198] ([unknown] [108.7.159.146]) by vms173015.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0M070077FKMPWK50@vms173015.mailsrvcs.net> for libffi-discuss@sourceware.org; Thu, 01 Mar 2012 07:40:07 -0600 (CST) Subject: Re: error in src/powerpc/ffi_darwin.c MIME-version: 1.0 (Apple Message framework v1084) Content-type: text/plain; charset=us-ascii From: Timothy Wall In-reply-to: <33421057.post@talk.nabble.com> Date: Thu, 01 Mar 2012 13:40:00 -0000 Cc: libffi-discuss@sourceware.org Content-transfer-encoding: quoted-printable Message-id: References: <33421057.post@talk.nabble.com> To: chennam Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2012/txt/msg00071.txt.bz2 That looks fine (although I think in general much of the bad_abi handling i= n libffi is broken). This doesn't affect your failing closure tests, does it? On Mar 1, 2012, at 8:14 AM, chennam wrote: >=20 > Hi Anthony, >=20 > I am testing libffi v 3.0.10 & 3.0.11 on PowerPC/AIX, I think there is an > error in src/powerpc/ffi_darwin.c=20=20 > 1. It misses a "break" for case FFI_AIX: > 2. It fails the testcases for FFI_BAD_ABI (e.g. err_bad_abi.c) >=20 >=20 > Here is the local modification I made: > Could you validate them ? >=20 > --- ffi_darwin.c (revision 229) > +++ ffi_darwin.c (working copy) > @@ -1065,11 +1065,12 @@ > closure->cif =3D cif; > closure->fun =3D fun; > closure->user_data =3D user_data; > + break; >=20 > default: >=20 > - FFI_ASSERT(0); > - break; > +// FFI_ASSERT(0); > + return FFI_BAD_ABI; > } > return FFI_OK; > } > --=20 > View this message in context: http://old.nabble.com/error-in-src-powerpc-= ffi_darwin.c-tp33421057p33421057.html > Sent from the Sourceware - libffi-discuss mailing list archive at Nabble.= com. >=20