From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 584E7385DC08 for ; Mon, 6 Apr 2020 18:00:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 584E7385DC08 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-wCRISKhpMd-tjXt2SsEijg-1; Mon, 06 Apr 2020 14:00:03 -0400 X-MC-Unique: wCRISKhpMd-tjXt2SsEijg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F3B0DBED; Mon, 6 Apr 2020 18:00:02 +0000 (UTC) Received: from ovpn-114-204.phx2.redhat.com (ovpn-114-204.phx2.redhat.com [10.3.114.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id B31A9118F4D; Mon, 6 Apr 2020 18:00:01 +0000 (UTC) Message-ID: Subject: Re: [PATCH libffi 2/4] Use a documented way to pass $compiler_vendor to DejaGNU From: Jeff Law Reply-To: law@redhat.com To: "Maciej W. Rozycki" , libffi-discuss@sourceware.org Cc: gcc-patches@gcc.gnu.org Date: Mon, 06 Apr 2020 12:00:01 -0600 In-Reply-To: References: Organization: Red Hat User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libffi-discuss@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libffi-discuss mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 18:00:06 -0000 On Fri, 2020-04-03 at 23:55 +0100, Maciej W. Rozycki via Gcc-patches wrote: > Use Autoconf substitution in the template used for extra DejaGNU site > configuration, which is a documented supported way to pass information > from the `configure' script, rather than resorting to a hack with > extracting an undocumented internal setting from `config.log' to pass > the compiler vendor to DejaGNU. No functional change (and no risk of > breakage with some Autoconf version anymore). > > Use AM_SUBST_NOTMAKE with the new substitution so as not to place it in > Makefile.in files, where it is not needed, and set the Autmoake version > requirement accordingly. > --- > Hi, > > I chose to use AM_SUBST_NOTMAKE so as not to clutter Makefile.in files > with the new variable as Automake does that by default. That however > requires the use of Automake 1.11 or newer. By the look of our sources > that shouldn't be an issue as far as I can tell, but the macro invocation > can be dropped along with the requirement if it would. > > Maciej > --- > Makefile.am | 3 ++- > configure.ac | 2 ++ > testsuite/lib/libffi.exp | 4 ---- > testsuite/local.exp.in | 1 + > 4 files changed, 5 insertions(+), 5 deletions(-) OK jeff >