public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: "Maciej W. Rozycki" <macro@wdc.com>
Cc: <gcc-patches@gcc.gnu.org>, <libffi-discuss@sourceware.org>,
	<golang-dev@googlegroups.com>, <zlib@gzip.org>
Subject: Re: [PATCH] Add `--with-install-sysroot=' configuration option
Date: Thu, 14 Nov 2019 03:06:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.21.1911140257160.24245@digraph.polyomino.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.21.1911140024080.13542@redsun52.ssa.fujisawa.hgst.com>

On Thu, 14 Nov 2019, Maciej W. Rozycki wrote:

>  Questions, comments, OK to apply?

1. This needs documentation in install.texi.

2. A common macro in config/ would be better than duplicating code in each 
configure.ac file.

3. To confirm (this should be made clear in the documentation), this is 
nonsensical given --enable-version-specific-runtime-libs?  If so, maybe 
the configure macro should give an error for the combination if possible.

4. How does this interact with sysroot suffixes (again, this should be 
made clear in the documentation)?

5. With this option, does the multilib OS directory (e.g. "../lib64") get 
used for anything at all outside the sysroot?  If not, is it valid with 
this option to have the same value of that directory for more than one 
multilib (that use different sysroot suffixes)?

(The basic complication in configurations with multiple sysroots is that 
the multilib OS directory currently gets used outside the sysroot, so 
needs to be unique.  But you also want a version that's only unique inside 
the sysroot - if you have sysroots for different CPU variants, each should 
have libraries in e.g. lib64 inside that sysroot.  At present, in such 
cases, you need to set STARTFILE_PREFIX_SPEC for the libraries to be found 
at link time inside the sysroot; see 
<https://gcc.gnu.org/ml/gcc/2016-12/msg00013.html> for some commentary on 
that.)

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2019-11-14  3:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14  2:47 Maciej W. Rozycki
2019-11-14  3:06 ` Joseph Myers [this message]
2019-11-18  2:04   ` [PATCH v2] " Maciej W. Rozycki
2019-11-19  0:11     ` Joseph Myers
2019-11-20  2:39       ` Maciej W. Rozycki
2019-11-20 17:46         ` Joseph Myers
2019-11-22 23:41           ` Maciej W. Rozycki
2019-11-22 23:54             ` Joseph Myers
2019-11-28 20:45               ` Maciej W. Rozycki
2019-11-28 21:06                 ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1911140257160.24245@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=golang-dev@googlegroups.com \
    --cc=libffi-discuss@sourceware.org \
    --cc=macro@wdc.com \
    --cc=zlib@gzip.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).