From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10342 invoked by alias); 20 Nov 2019 02:39:22 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 10319 invoked by uid 89); 20 Nov 2019 02:39:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=excerpt, sk:within, $toolexeclibdir, toolexeclibdir X-HELO: esa4.hgst.iphmx.com Received: from esa4.hgst.iphmx.com (HELO esa4.hgst.iphmx.com) (216.71.154.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2019 02:39:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1574217557; x=1605753557; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=Nw7x1GIdByyu9ZwB6gCqGWrkZobbUH8Ys/q+2x15g1M=; b=IB+B5Ga0ysrRURrOJcuYxAmaUPxPniA7SJAlV+CvAmhn/VnDfnbt16DZ wqEMCfV3DiDpX/b1N4lWsj729NrtFRHrUXoQH85e6m+7Sh4U3ltTIuDQd 8xw79w/WrUJPS0yVdWCF2UglyzQvm8pRBtyi4Bto8DUcIxYhD4cApZPTJ MGpd4K/CBCZzKospgVWyCklsnLVjv5jNGFVRA7PF3ULyb9QyjoP2Sy92g PKP8/y+HU643eyXCxad+VK3YtvbkWJne3cKHxTT6FSdQ2n87CYxaGICY7 1Xx3R+zxAIEVsVbAV24BSDVkA2JC8do/9Ngszsm1QfFLbAkFH9fAbYkR3 Q==; IronPort-SDR: iZpllQ0lo66nKHhtn+DGQSkADalLFzH8gvHYAHdAmxwUKl+SYBE0IuU6pezlokmcsNo1hL9ch8 5YsZR3aJxt2vRMVyyXJRoRMrCm+TJ26eCWdUdL2KvGJHTjDNWqv8okfKNrwyBJ87wfZ7UU3tUL Jx8OO273Fi8+1761+oU9S3nwVyS/pAjkCUbFKZPZkOlWBXksSIOryNjs5Uebe2Ny5AtaxN3PCW flA8e5FwLIvV+OgD3uulWESrE05rc5SJOLPSdYSaWKEI8Kjben5LbKNtqXJqFiu4dQ6sxNguK2 G4k= Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 20 Nov 2019 10:39:15 +0800 IronPort-SDR: TPSHQwzInuecWc4muofQVeS4OpLcT4idgUjhYTz87kBA5uPLGNhPWVLbu64/JbPlvrYP3+Ntda BPgThmdIJ74wZoJfg+L1/Z6S6ksphfXD2XrU5768E+GFyyx19Ny2pG9YQwIiMBgdGRJnTRo/rg GqmK/KI1ii1TteLKbcLWR/MtOmPsw3f2/FPNNW6CG5pTsYVjRwHqz7YbLIjFiFqxSk/yKn2ofw T/1AVDU0MMIBy1dQpSPo2ZGuBtcQRi3OposE8jPoaggyL93qJkzvzh+EHoVjvJw1jFzXTsj81S ov6Wv3nKtwflVGZ363ncIT0N Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 18:34:27 -0800 IronPort-SDR: soB0KTrKPGzl2XS9rPYISb6S3U7aDYVo7u11iAlGq9erxRvu410UYV5DAopNZuWRKKHjpHe4hs R0Yg3EsZ6e7u9fHeLTqdr58x1u8jDLhT3J1wEoIkn2hsAK6xbHcCk1lS61B/TtDsiQsVCRGR59 2E5oTnNR71DAGJLsjQFTRKhF2fzN3yO4tMKSDYCH+g47f9N4HIoHnElQyo10yT4+jibQwMv8+q 6PXotr7JkNguPhv4IwqhVo8cyBAKkYb+VsTvmKYLsnKSs5RSElds9Q9lLa9tjjULkNPGjD4Wb2 LfE= WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 18:39:15 -0800 Date: Wed, 20 Nov 2019 02:39:00 -0000 From: "Maciej W. Rozycki" To: Joseph Myers cc: gcc-patches@gcc.gnu.org, libffi-discuss@sourceware.org, golang-dev@googlegroups.com, zlib@gzip.org Subject: Re: [PATCH v2] Add `--with-install-sysroot=' configuration option In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2019/txt/msg00084.txt.bz2 On Tue, 19 Nov 2019, Joseph Myers wrote: > > > 4. How does this interact with sysroot suffixes (again, this should be > > > made clear in the documentation)? > > > > There is no interaction, the patch merely changes where the libraries are > > installed. If the installation sysroot directory chosen is not one known > > by the GCC driver, then the newly-installed target libraries won't be > > automatically used (that of course can be changed with the appropriate use > > of the `-B', `-L' and `--sysroot=' driver options). > > Perhaps the "sysroot" phrasing of the option name is confusing. > > The documentation in install.texi says "@var{dir} rather than > @option{$@{gcc_tooldir@}/lib}". If that means, for example, that when > "-print-multi-os-directory" prints "../lib64" the libraries are installed > in $dir/../lib64 (so you'd pass --with-install-sysroot=/some/where/lib > rather than --with-install-sysroot=/some/where), it's definitely not a > sysroot. If in fact $dir/lib/../lib64 would be used, the documentation > should say so. Documentation thinko here, thanks for your meticulousness! Indeed that has to read "@option{$@{gcc_tooldir@}}" as per example code: case ${with_install_sysroot} in no) toolexeclibdir='$(toolexecdir)/lib' ;; *) toolexeclibdir=${with_install_sysroot}/lib ;; esac where "@var{dir}" does get interpreted as a sysroot (as was also previously shown by my use example). > But even then, if you configure GCC using "--with-sysroot" or > "--with-build-sysroot", both of those paths are the top-level sysroot, to > which the sysroot suffix gets appended before GCC uses it for any purpose, > unless you explicitly build using --no-sysroot-suffix. So I still think > it's natural for a user of GCC's configure scripts to expect the new > option, like the other sysroot-related configure options, also to be one > to which the per-multilib sysroot suffix gets appended before GCC uses it. > And if it's not like that, the documentation needs to say so explicitly. Thanks for your concern, however again, AFAICT this change is tangential to any sysroot suffix, which necessarily has to be already included in the multilib OS directory as given by `-print-multi-os-directory', so that it gets embedded within $toolexeclibdir for the purpose of target library installation across the relevant subdirs, as per this excerpt from `configure' code right after the assignments quoted in the example above: multi_os_directory=`$CC -print-multi-os-directory` case $multi_os_directory in .) ;; # Avoid trailing /. *) toolexeclibdir=$toolexeclibdir/$multi_os_directory ;; esac or otherwise the existing arrangement where toolexeclibdir='$(toolexecdir)/lib' wouldn't have worked either (and neither would in the native case where toolexeclibdir='$(libdir)'). Does this answer clear your concern? OK to apply with the documentation thinko fixed? Maciej