public inbox for libffi-discuss@sourceware.org
 help / color / mirror / Atom feed
From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
To: libffi-discuss <libffi-discuss@sourceware.org>
Subject: Re: [RFC PATCH v1 1/4] Static Trampolines - Quick question
Date: Fri, 4 Dec 2020 20:38:12 -0600	[thread overview]
Message-ID: <edbe7b82-0d9a-7d29-6d32-22bdca2859d7@linux.microsoft.com> (raw)
In-Reply-To: <977a6824-c0b2-b69e-97ba-ce11639b4ba3@linux.microsoft.com>

Hi,

I am preparing version 2. I have a question. Are we allowed to change
FFI_TRAMPOLINE_SIZE, the size of closure->tramp[]? As an example,
I checked the git history for ARM. I can see that it has changed
a couple of times in the past. Just want to know if there would be any
compatibility issues if the size is changed.

My solution can be more elegant if the trampoline size can be changed.

I recall seeing somewhere that in some cases, a libffi consumer manages
closure memory and does not call ffi_closure_alloc() and ffi_closure_free().
In such cases, the consumer would have to be rebuilt if the closure size
changed. Do we still support such consumers? Is it OK for them to rebuild?
When the size of the closure structure changes, does the library version
have to be bumped up?

Please advise.

Thanks.

Madhavan

  reply	other threads:[~2020-12-05  2:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9bd94fd78a3c8f638b8a0d2269258da99d58e70f>
2020-11-24 19:32 ` [RFC PATCH v1 0/4] Libffi Static Trampolines madvenka
2020-11-24 19:32   ` [RFC PATCH v1 1/4] " madvenka
2020-11-24 19:49     ` Anthony Green
2020-11-24 20:02       ` Madhavan T. Venkataraman
2020-12-02 16:49       ` Madhavan T. Venkataraman
2020-12-02 18:14         ` Anthony Green
2020-12-02 21:33           ` Madhavan T. Venkataraman
2020-12-03 18:45             ` Madhavan T. Venkataraman
2020-12-05  2:38               ` Madhavan T. Venkataraman [this message]
2020-11-24 19:32   ` [RFC PATCH v1 2/4] x86: Support for " madvenka
2020-11-24 19:32   ` [RFC PATCH v1 3/4] aarch64: " madvenka
2020-11-24 19:32   ` [RFC PATCH v1 4/4] arm: " madvenka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edbe7b82-0d9a-7d29-6d32-22bdca2859d7@linux.microsoft.com \
    --to=madvenka@linux.microsoft.com \
    --cc=libffi-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).