From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29920 invoked by alias); 13 Nov 2010 07:12:45 -0000 Received: (qmail 29897 invoked by uid 22791); 13 Nov 2010 07:12:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_ADSP_NXDOMAIN,RCVD_IN_DNSWL_HI,SARE_FROM_MULTI_DASH,SPF_HELO_PASS,TW_BF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Nov 2010 07:12:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAD7BjGk026595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 13 Nov 2010 02:11:45 -0500 Received: from gmachine.redhat.com (vpn-9-88.rdu.redhat.com [10.11.9.88]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oAD7Bhl4029133; Sat, 13 Nov 2010 02:11:43 -0500 From: Anthony Green To: Jacek Caban Cc: libffi-discuss@sourceware.org Subject: Re: [PATCH] Fixed compilation on mingw-w64 after recent ABI change. In-Reply-To: <4CDA8C27.4050000@codeweavers.com> (Jacek Caban's message of "Wed, 10 Nov 2010 13:12:23 +0100") References: <4CD2C1BF.5060008@codeweavers.com> <4CDA8C27.4050000@codeweavers.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Date: Sat, 13 Nov 2010 07:12:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2010/txt/msg00179.txt.bz2 Jacek Caban writes: > On 11/4/10 3:22 PM, Jacek Caban wrote: >> Hi, >> >> mingw-w64 ABI has been recently changed to use nonunderscored symbol >> names (for compatibility with MSVC). The attached patch fixes libffi >> compilation with recent mingw-w64. For backward compatibility, I've >> added a configure check for underscored symbols. > > I've got no response in almost a week, is there something wrong with > this patch? libffi is a volunteer project for me, which means that contributors often have to be patient. The patch looks OK to me. There's one spelling error ("sumbols"). FWIW, I prefer libtool's autoconf macro for underscore prefix tests. It compiles code and looks at the nm output to see if symbols are prefixed or not. Your test uses x86 assembly code, although I realize that your #ifdef around the config test so that it will only be run on x86 hw. Please resubmit with the spelling fix and a proper ChangeLog file entry and I'll merge it in. If you switch to the portable '_' test, I'd be even happier, but it's not necessary. Thanks for your patch, Jacek! AG > > Jacek