From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12797 invoked by alias); 8 Feb 2011 15:51:12 -0000 Received: (qmail 12788 invoked by uid 22791); 8 Feb 2011 15:51:11 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Feb 2011 15:51:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p18Fp3lQ020179 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Feb 2011 10:51:03 -0500 Received: from localhost.localdomain.redhat.com (vpn-8-84.rdu.redhat.com [10.11.8.84]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p18Fp1tn000372; Tue, 8 Feb 2011 10:51:01 -0500 To: Oren Held Cc: libffi-discuss@sourceware.org Subject: Re: [PATCH] HPUX: fix dlmalloc build In-Reply-To: <4D1CBA42.4090909@il.ibm.com> (Oren Held's message of "Thu, 30 Dec 2010 18:58:42 +0200") References: <1293707067-16085-1-git-send-email-orenhe@il.ibm.com> <4D1CBA42.4090909@il.ibm.com> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) From: Anthony Green Date: Tue, 08 Feb 2011 15:51:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org X-SW-Source: 2011/txt/msg00042.txt.bz2 Oren Held writes: > I can think of three options, but not sure what's the smartest way: > 1. If we prefer the OS native mallinfo declaration: have autoconf add > #define HAVE_USR_INCLUDE_MALLOC_H if it's an HP that has 'struct > malloc' in its /usr/include/stdlib.h > > 2. If we prefer the libffi (dlmalloc.c) mallinfo decleration: > 2.a. Simply add #define _STRUCT_MALLINFO inside dlmalloc.c, in the block > that declares the mallinfo struct. There's a very low risk that this > constant would affect other OSes badly and cause the problem. > 2.b. Do the above only for HPUX - probably needs an autoconf change. > > The previously attached patch is the #2.a. solution. I'm not familiar > with autoconf, and I'm not very sure which 'struct mallinfo' > impementation to prefer, thus I didn't implement solution #1 or #2.b. I went with 2.a for now. I'll make a smarter patch if we discover any problems while testing the next release. Thanks! AG