From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46739 invoked by alias); 4 Jul 2019 00:19:44 -0000 Mailing-List: contact libffi-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libffi-discuss-owner@sourceware.org Received: (qmail 46730 invoked by uid 89); 4 Jul 2019 00:19:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 00:19:43 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E2CB30C584F for ; Thu, 4 Jul 2019 00:19:42 +0000 (UTC) Received: from greed.delorie.com (ovpn-122-150.rdu2.redhat.com [10.10.122.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9AEF6013C; Thu, 4 Jul 2019 00:19:41 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id x640Je6T024655; Wed, 3 Jul 2019 20:19:40 -0400 From: DJ Delorie To: Anthony Green Cc: libffi-discuss@sourceware.org, fweimer@redhat.com Subject: Re: segfault in ffi_data_to_code_pointer In-Reply-To: <878ste90dy.fsf@laptop.atgreen.org> (message from Anthony Green on Wed, 03 Jul 2019 19:14:17 -0400) Date: Thu, 04 Jul 2019 00:19:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019/txt/msg00021.txt.bz2 Anthony Green writes: > Thanks. This looks right to me. By "right" do you mean "wrong" ? > Perhaps they wrote this before ffi_closure_alloc() existed? I don't > remember when every bit was introduced... Looks like you need to > follow up with the ruby people. So... no need/desire/reason to change anything in libffi then? ;-)