From: DJ Delorie <dj@redhat.com>
To: Anthony Green <green@moxielogic.com>
Cc: libffi-discuss@sourceware.org
Subject: Re: Change in libffi behaviour -- large struct args
Date: Tue, 31 May 2022 19:16:25 -0400 [thread overview]
Message-ID: <xnpmjtqomu.fsf@greed.delorie.com> (raw)
In-Reply-To: <CACxje5-nDE_2zvwhjqri-0jq6v8KjqEt2nvvg-a1X68yPKtAGg@mail.gmail.com>
Anthony Green <green@moxielogic.com> writes:
>> While this is technically an ABI change, if the "old" ABI never worked,
>> I can't see how this would break anything by changing.
>
> I wouldn't even call this an ABI change. The new implementation will
> be ABI compatible. This is really a bug fix. In fact, some ports
> have always done the right thing.
Right, I was using ABI to mean "the ABI of the target we're composing a
foreign call for", not the call ABI of the libffi library.
If we could not correctly call functions that took large structures, and
now we can, we have changed the target ABI but shouldn't break any
existing software that worked correctly before.
I agree it's worth fixing, we just must be careful we actually *don't*
break any currently-working program.
prev parent reply other threads:[~2022-05-31 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 13:40 Anthony Green
2022-05-28 15:38 ` dancol
2022-05-28 15:50 ` Anthony Green
2022-05-29 14:09 ` Anthony Green
2022-05-31 15:53 ` DJ Delorie
2022-05-31 16:47 ` dancol
2022-05-31 16:55 ` Kaz Kylheku
2022-05-31 18:59 ` Anthony Green
2022-05-31 23:16 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnpmjtqomu.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=green@moxielogic.com \
--cc=libffi-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).