public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testbase)] libstdc++: Fix __gnu_test::input_iterator_wrapper::operator++(int)
Date: Tue,  2 Jun 2020 12:25:41 +0000 (GMT)	[thread overview]
Message-ID: <20200602122541.CFC0F383F849@sourceware.org> (raw)

https://gcc.gnu.org/g:118158b646d402b0fb5d760e4827611b731fe6f3

commit 118158b646d402b0fb5d760e4827611b731fe6f3
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Jun 1 18:30:47 2020 +0100

    libstdc++: Fix __gnu_test::input_iterator_wrapper::operator++(int)
    
    I noticed recently that our input_iterator_wrapper utility for writing
    tests has the following post-increment operator:
    
        void
        operator++(int)
        {
          ++*this;
        }
    
    That fails to meet the Cpp17InputIterator requirement that *r++ is
    valid. This change makes it return a non-void proxy type that can be
    deferenced to produce another proxy, which is convertible to the
    value_type. The second proxy converts to const T& to ensure it can't be
    written to.
    
            * testsuite/util/testsuite_iterators.h:
            (input_iterator_wrapper::operator++(int)): Return proxy object.

Diff:
---
 libstdc++-v3/testsuite/util/testsuite_iterators.h | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/util/testsuite_iterators.h b/libstdc++-v3/testsuite/util/testsuite_iterators.h
index 5be47f47915..71b672c85fa 100644
--- a/libstdc++-v3/testsuite/util/testsuite_iterators.h
+++ b/libstdc++-v3/testsuite/util/testsuite_iterators.h
@@ -208,6 +208,17 @@ namespace __gnu_test
   : public std::iterator<std::input_iterator_tag, typename remove_cv<T>::type,
 			 std::ptrdiff_t, T*, T&>
   {
+    struct post_inc_proxy
+    {
+      struct deref_proxy
+      {
+	T* ptr;
+	operator const T&() const { return *ptr; }
+      } p;
+
+      deref_proxy operator*() const { return p; }
+    };
+
   protected:
     input_iterator_wrapper() : ptr(0), SharedInfo(0)
     { }
@@ -266,10 +277,12 @@ namespace __gnu_test
       return *this;
     }
 
-    void
+    post_inc_proxy
     operator++(int)
     {
+      post_inc_proxy tmp = { { ptr } };
       ++*this;
+      return tmp;
     }
 
 #if __cplusplus >= 201103L


                 reply	other threads:[~2020-06-02 12:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602122541.CFC0F383F849@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).