From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 4128139D7401; Wed, 17 Jun 2020 19:17:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4128139D7401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1592421449; bh=+4vpnTmJoDOuYcquVFJ1U5zg7E4vP1VWIXT/OLxS3Ro=; h=From:To:Subject:Date:From; b=tTcGFkH3FRXuRcsL8B0yd7BLw4Zm1c6A0IGrKmhhAWeeT+lmDObg3eQwAZg6R0TqG Cw/4jCguP+uShbHl077NqRz4g3VeWhPvdFTX5WYMjGKlc253lqL97Na7IiHLXfqdMH G0+f8D9x4dsAYkrqoTbJ1F6e0ZCgWwqNPCVNNZpo= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc/devel/ranger] libstdc++: Also disable caching of reverse_view::begin() for common_ranges X-Act-Checkin: gcc X-Git-Author: Patrick Palka X-Git-Refname: refs/heads/devel/ranger X-Git-Oldrev: 08bf7bde9f2987b1c623d272cc71fc14a1622442 X-Git-Newrev: 77e596cf3c1b7bc11ba946394ed8d62a49157b49 Message-Id: <20200617191729.4128139D7401@sourceware.org> Date: Wed, 17 Jun 2020 19:17:29 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 19:17:29 -0000 https://gcc.gnu.org/g:77e596cf3c1b7bc11ba946394ed8d62a49157b49 commit 77e596cf3c1b7bc11ba946394ed8d62a49157b49 Author: Patrick Palka Date: Fri Feb 28 10:47:26 2020 -0500 libstdc++: Also disable caching of reverse_view::begin() for common_ranges When the underlying range models common_range, then reverse_view::begin() is already O(1) without caching. So we should disable the cache in this case too. libstdc++-v3/ChangeLog: * include/std/ranges (reverse_view::_S_needs_cached_begin): Set to false whenever the underlying range models common_range. Diff: --- libstdc++-v3/ChangeLog | 3 +++ libstdc++-v3/include/std/ranges | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 89e1f5bf952..0feef87cce6 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,8 @@ 2020-02-28 Patrick Palka + * include/std/ranges (reverse_view::_S_needs_cached_begin): Set to false + whenever the underlying range models common_range. + * include/std/ranges (__detail::_CachedPosition): New struct. (views::filter_view::_S_needs_cached_begin): New member variable. (views::filter_view::_M_cached_begin): New member variable. diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges index 2f773130979..19d3da950e7 100644 --- a/libstdc++-v3/include/std/ranges +++ b/libstdc++-v3/include/std/ranges @@ -3177,7 +3177,8 @@ namespace views private: _Vp _M_base = _Vp(); - static constexpr bool _S_needs_cached_begin = !random_access_range<_Vp>; + static constexpr bool _S_needs_cached_begin + = !common_range<_Vp> && !random_access_range<_Vp>; [[no_unique_address]] __detail::__maybe_empty_t<_S_needs_cached_begin, __detail::_CachedPosition<_Vp>> _M_cached_begin;