public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc/devel/ranger] libstdc++: allow string_view insertion to work with <iosfwd> (PR 94051)
Date: Wed, 17 Jun 2020 19:27:51 +0000 (GMT)	[thread overview]
Message-ID: <20200617192751.7C816396EC23@sourceware.org> (raw)

https://gcc.gnu.org/g:6a7052832a4791047b0ff4f18dcbb55c93a7336c

commit 6a7052832a4791047b0ff4f18dcbb55c93a7336c
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Mar 5 16:46:28 2020 +0000

    libstdc++: allow string_view insertion to work with <iosfwd> (PR 94051)
    
    I don't think this is actually required to compile, because using
    operator<< without a definition of the ostream doesn't seem valid to me.
    But it's easy to make it work.
    
            PR libstdc++/94051
            * include/std/string_view: Include <bits/ostream_insert.h>.
            * testsuite/21_strings/basic_string_view/inserters/94051.cc: New test.

Diff:
---
 libstdc++-v3/ChangeLog                             |  6 +++++
 libstdc++-v3/include/std/string_view               |  1 +
 .../basic_string_view/inserters/94051.cc           | 28 ++++++++++++++++++++++
 3 files changed, 35 insertions(+)

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index df3b040abca..fd4d502badd 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-05  Jonathan Wakely  <jwakely@redhat.com>
+
+	PR libstdc++/94051
+	* include/std/string_view: Include <bits/ostream_insert.h>.
+	* testsuite/21_strings/basic_string_view/inserters/94051.cc: New test.
+
 2020-03-04  Jonathan Wakely  <jwakely@redhat.com>
 
 	* include/bits/cpp_type_traits.h (__memcpyable): Fix comment.
diff --git a/libstdc++-v3/include/std/string_view b/libstdc++-v3/include/std/string_view
index ea5d547e006..99a81bb04fa 100644
--- a/libstdc++-v3/include/std/string_view
+++ b/libstdc++-v3/include/std/string_view
@@ -42,6 +42,7 @@
 #include <bits/functional_hash.h>
 #include <bits/int_limits.h>
 #include <bits/range_access.h>
+#include <bits/ostream_insert.h>
 
 namespace std _GLIBCXX_VISIBILITY(default)
 {
diff --git a/libstdc++-v3/testsuite/21_strings/basic_string_view/inserters/94051.cc b/libstdc++-v3/testsuite/21_strings/basic_string_view/inserters/94051.cc
new file mode 100644
index 00000000000..326669133d7
--- /dev/null
+++ b/libstdc++-v3/testsuite/21_strings/basic_string_view/inserters/94051.cc
@@ -0,0 +1,28 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++17" }
+// { dg-do compile { target c++17 } }
+
+#include <iosfwd>
+#include <string_view>
+
+void
+test01(std::ostream& os, std::string_view sv)
+{
+  os << sv;
+}


                 reply	other threads:[~2020-06-17 19:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617192751.7C816396EC23@sourceware.org \
    --to=aldyh@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).