public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc/devel/ranger] libstdc++: Change compile-only test to run
Date: Wed, 17 Jun 2020 19:32:47 +0000 (GMT)	[thread overview]
Message-ID: <20200617193247.327C43851C0C@sourceware.org> (raw)

https://gcc.gnu.org/g:3654d49d0ff651b2a78401bc2430428711e7d2eb

commit 3654d49d0ff651b2a78401bc2430428711e7d2eb
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Mar 10 09:47:15 2020 +0000

    libstdc++: Change compile-only test to run
    
    The 24_iterators/ostream_iterator/1.cc test uses VERIFY and so is
    obviously meant to have been run, not just compiled.
    
            * testsuite/23_containers/unordered_set/allocator/ext_ptr.cc: Add
            comment explaining multiple dg-do directives.
            * testsuite/24_iterators/ostream_iterator/1.cc: Fix do-do directive
            so test is run as well as compiled.

Diff:
---
 libstdc++-v3/ChangeLog                                             | 7 +++++++
 .../testsuite/23_containers/unordered_set/allocator/ext_ptr.cc     | 2 ++
 libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc          | 2 +-
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index be382dc4e63..bd4b7a80999 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,10 @@
+2020-03-10  Jonathan Wakely  <jwakely@redhat.com>
+
+	* testsuite/23_containers/unordered_set/allocator/ext_ptr.cc: Add
+	comment explaining multiple dg-do directives.
+	* testsuite/24_iterators/ostream_iterator/1.cc: Fix do-do directive
+	so test is run as well as compiled.
+
 2020-03-09  Jonathan Wakely  <jwakely@redhat.com>
 
 	PR libstdc++/94063
diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc
index 5cbc76e0d8c..f6b908ac03e 100644
--- a/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc
+++ b/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/ext_ptr.cc
@@ -15,6 +15,8 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
+// This test fails to compile since C++17 (see xfail-if below) so we can only
+// do a "run" test for C++11 and C++14, and a "compile" test for C++17 and up.
 // { dg-do run { target { c++11_only || c++14_only } } }
 // { dg-do compile { target c++17 } }
 
diff --git a/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc b/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc
index 640ff61afa7..718dad3b684 100644
--- a/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc
+++ b/libstdc++-v3/testsuite/24_iterators/ostream_iterator/1.cc
@@ -15,7 +15,7 @@
 // with this library; see the file COPYING3.  If not see
 // <http://www.gnu.org/licenses/>.
 
-// { dg-do compile { target c++11 } }
+// { dg-do run { target c++11 } }
 
 #include <iterator>
 #include <sstream>


                 reply	other threads:[~2020-06-17 19:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617193247.327C43851C0C@sourceware.org \
    --to=aldyh@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).