From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1698) id 4F5E0395ACC6; Wed, 17 Jun 2020 20:01:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F5E0395ACC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1592424089; bh=Il1Gl2U0/ceezIkl513eWeG3sdkL/zjVg2Z1TBxWM74=; h=From:To:Subject:Date:From; b=YlLUKcVI7PoOBc0+tU9QrfyGffnjGEAPM+NiGPjdIaebtWTfxeDY+5x/FFO+8U2IL pN4t5sU53OmqbV7ePf0VqRblTk4LuFidkHJmw323wbFeTZRn7+DlnWXkgCR1+O4ALH 15lh1aQbzmtP9uRvtOOfF1EnFR1h5aLhw4ltqtOo= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Iain D Sandoe To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc/devel/c++-coroutines] libstdc++: Enforce copyable/movable checks in std::atomic X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/devel/c++-coroutines X-Git-Oldrev: 15cf136abe0461f2bcf2ccf7a0e4e495f2362b75 X-Git-Newrev: cc799df98f6eaf73763a069f7854e490a0416573 Message-Id: <20200617200129.4F5E0395ACC6@sourceware.org> Date: Wed, 17 Jun 2020 20:01:29 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 20:01:29 -0000 https://gcc.gnu.org/g:cc799df98f6eaf73763a069f7854e490a0416573 commit cc799df98f6eaf73763a069f7854e490a0416573 Author: Jonathan Wakely Date: Tue Jun 16 22:34:55 2020 +0100 libstdc++: Enforce copyable/movable checks in std::atomic C++20 adds some new preconditions to std::atomic, which weren't previously checked by our implementation. * include/std/atomic (atomic): Add static assertions. * testsuite/29_atomics/atomic/requirements/types_neg.cc: New test. Diff: --- libstdc++-v3/include/std/atomic | 7 ++++ .../29_atomics/atomic/requirements/types_neg.cc | 43 ++++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/libstdc++-v3/include/std/atomic b/libstdc++-v3/include/std/atomic index a455286a784..2161cbed0d2 100644 --- a/libstdc++-v3/include/std/atomic +++ b/libstdc++-v3/include/std/atomic @@ -198,6 +198,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION static_assert(sizeof(_Tp) > 0, "Incomplete or zero-sized types are not supported"); +#if __cplusplus > 201703L + static_assert(is_copy_constructible_v<_Tp>); + static_assert(is_move_constructible_v<_Tp>); + static_assert(is_copy_assignable_v<_Tp>); + static_assert(is_move_assignable_v<_Tp>); +#endif + public: atomic() = default; ~atomic() noexcept = default; diff --git a/libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc b/libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc new file mode 100644 index 00000000000..4c58a9deba2 --- /dev/null +++ b/libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc @@ -0,0 +1,43 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-options "-std=gnu++2a" } +// { dg-do compile { target c++2a } } + +#include + +std::atomic a; // { dg-error "here" } + +struct MoveOnly +{ + MoveOnly() = default; + MoveOnly(MoveOnly&&) = default; + MoveOnly& operator=(MoveOnly&&) = default; +}; +std::atomic b; // { dg-error "here" } + +struct NoMove +{ + NoMove() = default; + NoMove(const NoMove&) = default; + NoMove& operator=(const NoMove&) = default; + NoMove(NoMove&&) = delete; + NoMove& operator=(NoMove&&) = delete; +}; +std::atomic c; // { dg-error "here" } + +// { dg-error "static assertion failed" "" { target *-*-* } 0 }