From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id F0D07396E811; Wed, 17 Jun 2020 20:32:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0D07396E811 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1592425957; bh=z/QW3kvYro+gn/oW6YDhI57gzbmAZoj3/GslcCdpLog=; h=From:To:Subject:Date:From; b=B+tgXOvtg5zeO85pvB/yRpSorj41nGzvQgO7dSM4fvVmaAsda5h4viHbI2wBIEBTP POGqxi9qV9ERzSweHyzeqwdPt7XiOPdrf6UqRjlukQXOZXFurDOKuBej6nAAantE4S ReuD1py9BWhwdKAMr7Y08kH/rR1X+oKugEKX2Xec= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc/devel/ranger] libstdc++: Fix redundant assignment (PR 94629) X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/devel/ranger X-Git-Oldrev: 36bc6c652099a5a08a6792b86ab442a0aa50c9a4 X-Git-Newrev: a2c0fa35d0dc8912b0c1a658234221de61e60840 Message-Id: <20200617203237.F0D07396E811@sourceware.org> Date: Wed, 17 Jun 2020 20:32:37 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 20:32:38 -0000 https://gcc.gnu.org/g:a2c0fa35d0dc8912b0c1a658234221de61e60840 commit a2c0fa35d0dc8912b0c1a658234221de61e60840 Author: Jonathan Wakely Date: Sun Apr 19 20:54:38 2020 +0100 libstdc++: Fix redundant assignment (PR 94629) This appears to be a copy&paste error, which cppcheck diagnoses. PR other/94629 * include/debug/formatter.h (_Error_formatter::_Parameter): Fix redundant assignment in constructor. Diff: --- libstdc++-v3/ChangeLog | 6 ++++++ libstdc++-v3/include/debug/formatter.h | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 40345cc7044..8d5f0a12fd6 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,9 @@ +2020-04-19 Jonathan Wakely + + PR other/94629 + * include/debug/formatter.h (_Error_formatter::_Parameter): Fix + redundant assignment in constructor. + 2020-04-18 Jonathan Wakely * include/std/chrono (duration, time_point): Define operator<=> and diff --git a/libstdc++-v3/include/debug/formatter.h b/libstdc++-v3/include/debug/formatter.h index 998f8056601..bb9b3e5653a 100644 --- a/libstdc++-v3/include/debug/formatter.h +++ b/libstdc++-v3/include/debug/formatter.h @@ -299,7 +299,6 @@ namespace __gnu_debug _M_variant._M_iterator._M_name = __name; _M_variant._M_iterator._M_address = std::__addressof(__it); _M_variant._M_iterator._M_type = _GLIBCXX_TYPEID(_Iterator); - _M_variant._M_iterator._M_constness = _M_variant._M_iterator._M_constness = __it._S_constant() ? __const_iterator : __mutable_iterator; _M_variant._M_iterator._M_sequence = __it._M_get_sequence();