public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc/devel/ranger] libstdc++: Avoid illegal argument to verbose in dg-test callback
Date: Wed, 17 Jun 2020 20:33:39 +0000 (GMT)	[thread overview]
Message-ID: <20200617203339.3CC5A396E869@sourceware.org> (raw)

https://gcc.gnu.org/g:697b94cfaef4a958132faf0cf4b35b15dfb29acc

commit 697b94cfaef4a958132faf0cf4b35b15dfb29acc
Author: Matthias Kretz <kretz@kde.org>
Date:   Mon Apr 20 15:29:41 2020 +0100

    libstdc++: Avoid illegal argument to verbose in dg-test callback
    
    If extra_tool_flags starts with a dash, an error like 'ERROR: verbose:
    illegal argument: -march=native -O2 -std=c++17' is printed. This is
    easily fixed by inserting a double dash before the variable.
    
    2020-04-20  Matthias Kretz  <kretz@kde.org>
    
            * testsuite/lib/libstdc++.exp: Avoid illegal argument to verbose.

Diff:
---
 libstdc++-v3/ChangeLog                   | 4 ++++
 libstdc++-v3/testsuite/lib/libstdc++.exp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index fde5ac1bf37..b30b1d096e8 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,7 @@
+2020-04-20  Matthias Kretz  <kretz@kde.org>
+
+	* testsuite/lib/libstdc++.exp: Avoid illegal argument to verbose.
+
 2020-04-19  Jonathan Wakely  <jwakely@redhat.com>
 
 	* include/bits/stl_queue.h (queue): Define operator<=> for C++20.
diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 10a7e748464..7f4532c55b2 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -408,7 +408,7 @@ proc libstdc++-dg-test { prog do_what extra_tool_flags } {
     set options ""
     if { $extra_tool_flags != "" } {
 	verbose -log "extra_tool_flags are:"
-	verbose -log $extra_tool_flags
+	verbose -log -- $extra_tool_flags
 	if { [string first "-x c" $extra_tool_flags ] != -1 } {
 	    verbose -log "compiling and executing as C, not C++"
 	    set edit_tool_flags $extra_tool_flags


                 reply	other threads:[~2020-06-17 20:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617203339.3CC5A396E869@sourceware.org \
    --to=aldyh@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).