public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc/devel/c++-modules] libstdc++: Define std::bad_optional_access constructor as defaulted
Date: Thu, 25 Jun 2020 14:27:20 +0000 (GMT)	[thread overview]
Message-ID: <20200625142720.C2908386F83C@sourceware.org> (raw)

https://gcc.gnu.org/g:d3647057913d3671312a79a77be02fc459d89fb6

commit d3647057913d3671312a79a77be02fc459d89fb6
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jun 9 22:13:37 2020 +0100

    libstdc++: Define std::bad_optional_access constructor as defaulted
    
    The standard requires that std::bad_optional_access' default
    constructor has a non-throwing exception specification.
    
            * include/std/optional (bad_optional_access): Define default
            constructor and destructor as defaulted.
            * testsuite/20_util/optional/bad_access.cc: New test.

Diff:
---
 libstdc++-v3/include/std/optional                  |  7 +++---
 .../testsuite/20_util/optional/bad_access.cc       | 27 ++++++++++++++++++++++
 2 files changed, 30 insertions(+), 4 deletions(-)

diff --git a/libstdc++-v3/include/std/optional b/libstdc++-v3/include/std/optional
index 37c2ba7a025..b0184a4e1c0 100644
--- a/libstdc++-v3/include/std/optional
+++ b/libstdc++-v3/include/std/optional
@@ -84,12 +84,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
   class bad_optional_access : public exception
   {
   public:
-    bad_optional_access() { }
+    bad_optional_access() = default;
+    virtual ~bad_optional_access() = default;
 
-    virtual const char* what() const noexcept override
+    const char* what() const noexcept override
     { return "bad optional access"; }
-
-    virtual ~bad_optional_access() noexcept = default;
   };
 
   void
diff --git a/libstdc++-v3/testsuite/20_util/optional/bad_access.cc b/libstdc++-v3/testsuite/20_util/optional/bad_access.cc
new file mode 100644
index 00000000000..6ebb3e2b19e
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/optional/bad_access.cc
@@ -0,0 +1,27 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++17" }
+// { dg-do compile { target c++17 } }
+
+#include <optional>
+
+using std::bad_optional_access;
+
+static_assert( std::is_nothrow_default_constructible_v<bad_optional_access> );
+static_assert( std::is_nothrow_copy_constructible_v<bad_optional_access> );
+static_assert( std::is_nothrow_copy_assignable_v<bad_optional_access> );


                 reply	other threads:[~2020-06-25 14:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200625142720.C2908386F83C@sourceware.org \
    --to=nathan@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).