From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1059) id D6F12386F83C; Thu, 25 Jun 2020 14:27:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6F12386F83C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1593095245; bh=a4UxyivSomhflCWJw2W1goxuqo3SuRbJDOpSjpmGCjU=; h=From:To:Subject:Date:From; b=HoV/vRwH3sRyUtXbtukc2VJlyALg04wJRQ0fZ7viD3RL2GmZjpgW0bGRFDQ52kV03 pUbOCIoO2ANz0TieFN+udh5nuAm0EAwQheRRckCr2EnUdJ+xUXGvNxFORWHGCFijFG L9mwJGX5ZLNSBj8Us+z4SguexnPxCqA+qv4p62+M= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Nathan Sidwell To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc/devel/c++-modules] libstdc++: Define converting assignment operator for std::move_iterator X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/devel/c++-modules X-Git-Oldrev: d3647057913d3671312a79a77be02fc459d89fb6 X-Git-Newrev: 733167f9d5ca5b9417559b7362d91e967be95a01 Message-Id: <20200625142725.D6F12386F83C@sourceware.org> Date: Thu, 25 Jun 2020 14:27:25 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 14:27:25 -0000 https://gcc.gnu.org/g:733167f9d5ca5b9417559b7362d91e967be95a01 commit 733167f9d5ca5b9417559b7362d91e967be95a01 Author: Jonathan Wakely Date: Tue Jun 9 22:16:24 2020 +0100 libstdc++: Define converting assignment operator for std::move_iterator As clarified by LWG 3265, std::move_iterator is supposed to have an assignment operator that converts from a different specialization of std::move_iterator, which performs an assignment. That has always been missing from libstdc++, so assigning a different type actually performs a converting construction, then an assignment. This is non-conforming for the (fairly contrived) case where the converting assignment is well-formed but the converting construction is not. * include/bits/stl_iterator.h (move_iterator::operator=): Define. * testsuite/24_iterators/move_iterator/dr3265.cc: New test. Diff: --- libstdc++-v3/include/bits/stl_iterator.h | 8 ++++ .../testsuite/24_iterators/move_iterator/dr3265.cc | 51 ++++++++++++++++++++++ 2 files changed, 59 insertions(+) diff --git a/libstdc++-v3/include/bits/stl_iterator.h b/libstdc++-v3/include/bits/stl_iterator.h index 72907813bf5..6d2d19eb068 100644 --- a/libstdc++-v3/include/bits/stl_iterator.h +++ b/libstdc++-v3/include/bits/stl_iterator.h @@ -1307,6 +1307,14 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION move_iterator(const move_iterator<_Iter>& __i) : _M_current(__i.base()) { } + template + _GLIBCXX17_CONSTEXPR + move_iterator& operator=(const move_iterator<_Iter>& __i) + { + _M_current = __i.base(); + return *this; + } + #if __cplusplus <= 201703L _GLIBCXX17_CONSTEXPR iterator_type base() const diff --git a/libstdc++-v3/testsuite/24_iterators/move_iterator/dr3265.cc b/libstdc++-v3/testsuite/24_iterators/move_iterator/dr3265.cc new file mode 100644 index 00000000000..05327e979ac --- /dev/null +++ b/libstdc++-v3/testsuite/24_iterators/move_iterator/dr3265.cc @@ -0,0 +1,51 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do compile { target c++11 } } + +#include + +struct Iter +{ + using iterator_category = std::forward_iterator_tag; + using value_type = int; + using pointer = int*; + using reference = int&; + using difference_type = std::ptrdiff_t; + + Iter(); + + // Construction from int* is not valid: + Iter(int*) = delete; + + // Assignment from int* is valid: + Iter& operator=(int*); + + Iter& operator++(); + Iter operator++(int); + int& operator*() const; + int* operator->() const; + + template friend bool operator==(Iter, Iter); +}; + +void test01() +{ + std::move_iterator m; + int i = 0; + m = std::make_move_iterator(&i); // Should use assignment not construction +}