public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: William Schmidt <wschmidt@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc(refs/users/wschmidt/heads/builtins3)] libstdc++: cv bool can't be an integer-like type (LWG 3467)
Date: Tue, 18 Aug 2020 18:16:55 +0000 (GMT)	[thread overview]
Message-ID: <20200818181655.69881386F804@sourceware.org> (raw)

https://gcc.gnu.org/g:9e67b4356efe4291fdb170fb116092f4ed9d2f05

commit 9e67b4356efe4291fdb170fb116092f4ed9d2f05
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Jul 30 12:23:55 2020 +0100

    libstdc++: cv bool can't be an integer-like type (LWG 3467)
    
    libstdc++-v3/ChangeLog:
    
            * include/bits/iterator_concepts.h (__detail::__cv_bool): New
            helper concept.
            (__detail::__integral_nonbool): Likewise.
            (__detail::__is_integer_like): Use __integral_nonbool.
            * testsuite/std/ranges/access/lwg3467.cc: New test.

Diff:
---
 libstdc++-v3/include/bits/iterator_concepts.h      |  8 +++++-
 .../testsuite/std/ranges/access/lwg3467.cc         | 33 ++++++++++++++++++++++
 2 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/bits/iterator_concepts.h b/libstdc++-v3/include/bits/iterator_concepts.h
index e56abe2be6c..aad6c2dcd91 100644
--- a/libstdc++-v3/include/bits/iterator_concepts.h
+++ b/libstdc++-v3/include/bits/iterator_concepts.h
@@ -520,7 +520,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 #endif
 
     template<typename _Tp>
-      concept __is_integer_like = integral<_Tp>
+      concept __cv_bool = same_as<const volatile _Tp, const volatile bool>;
+
+    template<typename _Tp>
+      concept __integral_nonbool = integral<_Tp> && !__cv_bool<_Tp>;
+
+    template<typename _Tp>
+      concept __is_integer_like = __integral_nonbool<_Tp>
 	|| same_as<_Tp, __max_diff_type> || same_as<_Tp, __max_size_type>;
 
     template<typename _Tp>
diff --git a/libstdc++-v3/testsuite/std/ranges/access/lwg3467.cc b/libstdc++-v3/testsuite/std/ranges/access/lwg3467.cc
new file mode 100644
index 00000000000..23418b476a0
--- /dev/null
+++ b/libstdc++-v3/testsuite/std/ranges/access/lwg3467.cc
@@ -0,0 +1,33 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+// LWG 3467. bool can't be an integer-like type
+
+#include <ranges>
+
+struct R
+{
+  bool size() const;
+};
+
+template<typename T>
+concept sized = requires(T t) { std::ranges::size(t); };
+
+static_assert( !sized<R> );


                 reply	other threads:[~2020-08-18 18:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818181655.69881386F804@sourceware.org \
    --to=wschmidt@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).