public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Giuliano Belinassi <giulianob@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc/devel/autopar_devel] libstdc++: Fix function that can't be constexpr in C++11 (PR 95289) Date: Sat, 22 Aug 2020 21:32:00 +0000 (GMT) [thread overview] Message-ID: <20200822213200.421893877021@sourceware.org> (raw) https://gcc.gnu.org/g:5173c2aa7ab6c6ec3152aec33e374e1cbec5de17 commit 5173c2aa7ab6c6ec3152aec33e374e1cbec5de17 Author: Jonathan Wakely <jwakely@redhat.com> Date: Sat May 23 18:27:35 2020 +0100 libstdc++: Fix function that can't be constexpr in C++11 (PR 95289) The body of this function isn't just a return statement, so it can't be constexpr until C++14. PR libstdc++/95289 * include/debug/helper_functions.h (__get_distance): Only declare as a constexpr function for C++14 and up. * testsuite/25_algorithms/copy/debug/95289.cc: New test. Diff: --- libstdc++-v3/ChangeLog | 5 ++++ libstdc++-v3/include/debug/helper_functions.h | 2 +- .../testsuite/25_algorithms/copy/debug/95289.cc | 31 ++++++++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 08a2ad3330c..167cb88b592 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,10 @@ 2020-05-23 Jonathan Wakely <jwakely@redhat.com> + PR libstdc++/95289 + * include/debug/helper_functions.h (__get_distance): Only declare + as a constexpr function for C++14 and up. + * testsuite/25_algorithms/copy/debug/95289.cc: New test. + * include/bits/fs_path.h (__detail::_S_range_begin) (__detail::_S_range_end, path::_S_string_from_iter): Replace with overloaded function template __detail::__effective_range. diff --git a/libstdc++-v3/include/debug/helper_functions.h b/libstdc++-v3/include/debug/helper_functions.h index 251582d5922..62d5309257f 100644 --- a/libstdc++-v3/include/debug/helper_functions.h +++ b/libstdc++-v3/include/debug/helper_functions.h @@ -96,7 +96,7 @@ namespace __gnu_debug { return std::make_pair(__rhs - __lhs, __dp_exact); } template<typename _Iterator> - _GLIBCXX_CONSTEXPR + _GLIBCXX14_CONSTEXPR inline typename _Distance_traits<_Iterator>::__type __get_distance(_Iterator __lhs, _Iterator __rhs, std::input_iterator_tag) diff --git a/libstdc++-v3/testsuite/25_algorithms/copy/debug/95289.cc b/libstdc++-v3/testsuite/25_algorithms/copy/debug/95289.cc new file mode 100644 index 00000000000..bcdab19761f --- /dev/null +++ b/libstdc++-v3/testsuite/25_algorithms/copy/debug/95289.cc @@ -0,0 +1,31 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-options "-std=gnu++11 -D_GLIBCXX_DEBUG" } +// { dg-do compile { target c++11_only } } + +#include <algorithm> +#include <iterator> +#include <istream> + +// PR libstdc++/95289 + +void +test01(std::istream_iterator<char> i, char* out) +{ + std::copy(i, decltype(i){}, out); +}
reply other threads:[~2020-08-22 21:32 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200822213200.421893877021@sourceware.org \ --to=giulianob@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).