public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Giuliano Belinassi <giulianob@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc/devel/autopar_devel] libstdc++: Add new testcase for comparison category types
Date: Sat, 22 Aug 2020 21:37:56 +0000 (GMT)	[thread overview]
Message-ID: <20200822213756.8A3A9385DC37@sourceware.org> (raw)

https://gcc.gnu.org/g:9196de6c3b5b6392340cccb42f28e27eb1ec5942

commit 9196de6c3b5b6392340cccb42f28e27eb1ec5942
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed May 27 13:13:19 2020 +0100

    libstdc++: Add new testcase for comparison category types
    
    Comparing a comparison category type to anything except a literal 0 is
    undefined. This verifies that at least some misuses are diagnosed at
    compile time.
    
            * testsuite/18_support/comparisons/categories/zero_neg.cc: New test.

Diff:
---
 .../18_support/comparisons/categories/zero_neg.cc  | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/libstdc++-v3/testsuite/18_support/comparisons/categories/zero_neg.cc b/libstdc++-v3/testsuite/18_support/comparisons/categories/zero_neg.cc
new file mode 100644
index 00000000000..0a8af41acb9
--- /dev/null
+++ b/libstdc++-v3/testsuite/18_support/comparisons/categories/zero_neg.cc
@@ -0,0 +1,46 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+#include <compare>
+
+// C++20 [cmp.categories.pre]
+// "an argument other than a literal 0 is undefined"
+
+void
+test01()
+{
+  std::partial_ordering::equivalent == 0; // OK
+  std::weak_ordering::equivalent == 0;    // OK
+  std::strong_ordering::equivalent == 0;  // OK
+
+  std::partial_ordering::equivalent == 1; // { dg-error "invalid conversion" }
+  std::weak_ordering::equivalent == 1;    // { dg-error "invalid conversion" }
+  std::strong_ordering::equivalent == 1;  // { dg-error "invalid conversion" }
+
+  constexpr void* p = nullptr;
+  std::partial_ordering::equivalent == p; // { dg-error "invalid conversion" }
+  std::weak_ordering::equivalent == p;    // { dg-error "invalid conversion" }
+  std::strong_ordering::equivalent == p;  // { dg-error "invalid conversion" }
+
+  // Ideally these would be ill-formed, but the current code accepts it.
+  std::partial_ordering::equivalent == nullptr;
+  std::weak_ordering::equivalent == nullptr;
+  std::strong_ordering::equivalent == nullptr;
+}


                 reply	other threads:[~2020-08-22 21:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200822213756.8A3A9385DC37@sourceware.org \
    --to=giulianob@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).