public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r11-2979] libstdc++: Break header cycle between <new> and <exception> Date: Wed, 2 Sep 2020 13:13:40 +0000 (GMT) [thread overview] Message-ID: <20200902131340.DE3973870891@sourceware.org> (raw) https://gcc.gnu.org/g:6bdbf0f37bda2587a4e82cbb956de7a159a397ae commit r11-2979-g6bdbf0f37bda2587a4e82cbb956de7a159a397ae Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed Sep 2 13:27:57 2020 +0100 libstdc++: Break header cycle between <new> and <exception> The <new> and <exception> headers each include each other, which makes building them as header-units "exciting". The <new> header only needs the definition of std::exception (in order to derive from it) which is already in its own header, so just include that. libstdc++-v3/ChangeLog: * include/bits/stl_iterator.h: Include <bits/exception_defines.h> for definitions of __try, __catch and __throw_exception_again. (counted_iterator::operator++(int)): Use __throw_exception_again instead of throw. * libsupc++/new: Include <bits/exception.h> not <exception>. * libsupc++/new_opvnt.cc: Include <bits/exception_defines.h>. * testsuite/18_support/destroying_delete.cc: Include <type_traits> for std::is_same_v definition. * testsuite/20_util/variant/index_type.cc: Qualify size_t. Diff: --- libstdc++-v3/include/bits/stl_iterator.h | 3 ++- libstdc++-v3/libsupc++/new | 4 ++-- libstdc++-v3/libsupc++/new_opvnt.cc | 3 ++- libstdc++-v3/testsuite/18_support/destroying_delete.cc | 1 + libstdc++-v3/testsuite/20_util/variant/index_type.cc | 2 +- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/libstdc++-v3/include/bits/stl_iterator.h b/libstdc++-v3/include/bits/stl_iterator.h index f0cf4c55c09..da740e3732e 100644 --- a/libstdc++-v3/include/bits/stl_iterator.h +++ b/libstdc++-v3/include/bits/stl_iterator.h @@ -79,6 +79,7 @@ #if __cplusplus > 201703L # include <compare> # include <new> +# include <bits/exception_defines.h> # include <bits/iterator_concepts.h> #endif @@ -2062,7 +2063,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION return _M_current++; } __catch(...) { ++_M_length; - throw; + __throw_exception_again; } } diff --git a/libstdc++-v3/libsupc++/new b/libstdc++-v3/libsupc++/new index ebd1c490282..21848a573d1 100644 --- a/libstdc++-v3/libsupc++/new +++ b/libstdc++-v3/libsupc++/new @@ -38,7 +38,7 @@ #pragma GCC system_header #include <bits/c++config.h> -#include <exception> +#include <bits/exception.h> #pragma GCC visibility push(default) @@ -52,7 +52,7 @@ namespace std * * @c bad_alloc (or classes derived from it) is used to report allocation * errors from the throwing forms of @c new. */ - class bad_alloc : public exception + class bad_alloc : public exception { public: bad_alloc() throw() { } diff --git a/libstdc++-v3/libsupc++/new_opvnt.cc b/libstdc++-v3/libsupc++/new_opvnt.cc index 9f9dace5778..771696d4ba6 100644 --- a/libstdc++-v3/libsupc++/new_opvnt.cc +++ b/libstdc++-v3/libsupc++/new_opvnt.cc @@ -25,7 +25,8 @@ #include <bits/c++config.h> #include "new" - +#include "exception_defines.h" + _GLIBCXX_WEAK_DEFINITION void* operator new[] (std::size_t sz, const std::nothrow_t&) noexcept { diff --git a/libstdc++-v3/testsuite/18_support/destroying_delete.cc b/libstdc++-v3/testsuite/18_support/destroying_delete.cc index 96134d7e010..f0c9bb9fa25 100644 --- a/libstdc++-v3/testsuite/18_support/destroying_delete.cc +++ b/libstdc++-v3/testsuite/18_support/destroying_delete.cc @@ -19,6 +19,7 @@ // { dg-do run { target c++2a } } #include <new> +#include <type_traits> #include <testsuite_hooks.h> #ifndef __cpp_lib_destroying_delete diff --git a/libstdc++-v3/testsuite/20_util/variant/index_type.cc b/libstdc++-v3/testsuite/20_util/variant/index_type.cc index 73863fa677f..1c44758363c 100644 --- a/libstdc++-v3/testsuite/20_util/variant/index_type.cc +++ b/libstdc++-v3/testsuite/20_util/variant/index_type.cc @@ -22,4 +22,4 @@ #include <variant> static_assert(sizeof(std::variant<signed char, unsigned char>) - < sizeof(size_t)); + < sizeof(std::size_t));
reply other threads:[~2020-09-02 13:13 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200902131340.DE3973870891@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).