public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: H.J. Lu <hjl@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r11-6746] libstdc++-v3: Add -fcf-protection=none to -march=i486
Date: Sat, 16 Jan 2021 02:03:14 +0000 (GMT)	[thread overview]
Message-ID: <20210116020314.2E5DB3851C29@sourceware.org> (raw)

https://gcc.gnu.org/g:2c356f221bbab29bf4d1626d161e0f584dddd600

commit r11-6746-g2c356f221bbab29bf4d1626d161e0f584dddd600
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Jan 15 17:27:53 2021 -0800

    libstdc++-v3: Add -fcf-protection=none to -march=i486
    
    -fcf-protection is automatically enabled in libstdc++ on Linux/x86.
    Starting from
    
    commit 77d372abec0fbf2cfe922e3140ee3410248f979e
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Jan 14 05:56:46 2021 -0800
    
        x86: Error on -fcf-protection with incompatible target
    
    GCC issues an error on -fcf-protection with incompatible target:
    
    ... -fcf-protection ... libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc  -m32   -O2 -g0 -fno-exceptions -fno-asynchronous-unwind-tables -march=i486 ...
    cc1plus: error: '-fcf-protection' is not compatible with this target
    FAIL: 29_atomics/atomic_flag/test_and_set/explicit-hle.cc (test for excess errors)
    
    Add -fcf-protection=none to -march=i486 to compile explicit-hle.cc.
    
            * testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc:
            Add -fcf-protection=none to -march=i486.

Diff:
---
 .../testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc
index 0fd81709688..8ec46283208 100644
--- a/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc
+++ b/libstdc++-v3/testsuite/29_atomics/atomic_flag/test_and_set/explicit-hle.cc
@@ -1,6 +1,6 @@
 // { dg-do compile { target i?86-*-* x86_64-*-* } }
 // { dg-options "-O2 -g0 -fno-exceptions -fno-asynchronous-unwind-tables" }
-// { dg-additional-options "-march=i486" { target ia32 } }
+// { dg-additional-options "-march=i486 -fcf-protection=none" { target ia32 } }
 // { dg-require-effective-target c++11 }
 // { dg-skip-if "scans fail with LTO" { lto } { "-flto" } }
 // { dg-final { scan-assembler-times "xacquire\|\.byte\[^\n\r]*0xf2" 14 } }


                 reply	other threads:[~2021-01-16  2:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210116020314.2E5DB3851C29@sourceware.org \
    --to=hjl@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).