From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 56FD5386F47A; Thu, 4 Mar 2021 10:31:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56FD5386F47A MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r11-7503] libstdc++: Fix buffer overflows in tests [PR 99382] X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: f65e551f737ee3cb3a6ae45bd8168d959feacfa1 X-Git-Newrev: 905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77 Message-Id: <20210304103139.56FD5386F47A@sourceware.org> Date: Thu, 4 Mar 2021 10:31:39 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2021 10:31:39 -0000 https://gcc.gnu.org/g:905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77 commit r11-7503-g905ce0ca30cb33cddf024b0aebf4ba0b2c86fe77 Author: Jonathan Wakely Date: Thu Mar 4 10:28:38 2021 +0000 libstdc++: Fix buffer overflows in tests [PR 99382] This seems to be a typo/thinko in the definition of the arrays used as storage. libstdc++-v3/ChangeLog: PR libstdc++/99382 * testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc: Make storage larger than required. Verify no write to the last element. * testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc: Likewise. Diff: --- .../specialized_algorithms/uninitialized_default_n/sizes.cc | 4 +++- .../uninitialized_value_construct_n/sizes.cc | 7 ++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc index fbe14d41ed7..1a1aba4d5b0 100644 --- a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc +++ b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_default_n/sizes.cc @@ -41,10 +41,12 @@ test02() int operator>(void*) { return value != 0; } }; - int i[3]; + int i[5] = { 1, 2, 3, 4, 5 }; Size n = {4}; auto j = std::__uninitialized_default_n(i, n); VERIFY( j == (i + 4) ); + // i[0:3] are default-initialized so have indeterminate values. + VERIFY( i[4] == 5 ); } int diff --git a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc index d227de4fd80..5833f7ed6c3 100644 --- a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc +++ b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_value_construct_n/sizes.cc @@ -42,10 +42,15 @@ test02() int operator>(void*) { return value != 0; } }; - int i[3]; + int i[5] = { 1, 2, 3, 4, 5 }; Size n = {4}; auto j = std::__uninitialized_default_n(i, n); VERIFY( j == (i + 4) ); + VERIFY( i[0] == 0 ); + VERIFY( i[1] == 0 ); + VERIFY( i[2] == 0 ); + VERIFY( i[3] == 0 ); + VERIFY( i[4] == 5 ); } int