public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] require et random_device for cons token test
Date: Tue, 23 Mar 2021 12:33:55 +0000 (GMT)	[thread overview]
Message-ID: <20210323123355.88155385701F@sourceware.org> (raw)

https://gcc.gnu.org/g:daf640878b9ac2d7b9beb70803b4eaa0c104419e

commit daf640878b9ac2d7b9beb70803b4eaa0c104419e
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Mar 23 09:28:10 2021 -0300

    require et random_device for cons token test
    
    On target systems that don't support any random_device, not even the
    default one, other random_device constructor tests are disabled by
    dg-require-effective-target random_device.  The token.cc also
    exercises the default constructor, in a way that doesn't expect an
    exception to be raised, but it's not guarded by the same requirement.
    
    Other potentially-raising ctors in token.cc expect exceptions and
    handle them, but the ("default")-constructed one does not, so the
    program terminates and the test fails without exercising the other
    constructor variants.
    
    This patch arranges to disable the test altogether when the
    random_device feature is not available.  A reasonable alternative
    would be to install a std::runtime_error handler around the test01
    body, so that we exercise at least the exception raising, but then
    test03 would have to be relaxed, since without even "default", it
    likely wouldn't meet the tested requirement there.
    
    
    for  libstdc++-v3/ChangeLog
    
            * testsuite/26_numerics/random/random_device/cons/token.cc:
            Require effective target feature random_device.

Diff:
---
 libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc b/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc
index defb8d58c58..105ae0ba877 100644
--- a/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc
+++ b/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc
@@ -1,4 +1,5 @@
 // { dg-do run { target c++11 } }
+// { dg-require-effective-target random_device }
 // { dg-require-cstdint "" }
 //
 // 2008-11-24  Edward M. Smith-Rowland <3dw4rd@verizon.net>


             reply	other threads:[~2021-03-23 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 12:33 Alexandre Oliva [this message]
2021-03-24  6:29 Alexandre Oliva
2021-03-24  9:07 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323123355.88155385701F@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).