From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2140) id 228473858002; Wed, 24 Mar 2021 09:07:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 228473858002 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandre Oliva To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] require et random_device for cons token test X-Act-Checkin: gcc X-Git-Author: Alexandre Oliva X-Git-Refname: refs/users/aoliva/heads/testme X-Git-Oldrev: 9eec7c7686aedc79853699549d1c9eee0a0a84fd X-Git-Newrev: 0a5f899441bb67a245b6833ac399e678f8f42633 Message-Id: <20210324090748.228473858002@sourceware.org> Date: Wed, 24 Mar 2021 09:07:48 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 09:07:48 -0000 https://gcc.gnu.org/g:0a5f899441bb67a245b6833ac399e678f8f42633 commit 0a5f899441bb67a245b6833ac399e678f8f42633 Author: Alexandre Oliva Date: Wed Mar 24 05:50:36 2021 -0300 require et random_device for cons token test On target systems that don't support any random_device, not even the default one, other random_device constructor tests are disabled by dg-require-effective-target random_device. The token.cc also exercises the default constructor, in a way that doesn't expect an exception to be raised, but it's not guarded by the same requirement. Other potentially-raising ctors in token.cc expect exceptions and handle them, but the ("default")-constructed one does not, so the program terminates and the test fails without exercising the other constructor variants. This patch arranges to disable the test altogether when the random_device feature is not available. A reasonable alternative would be to install a std::runtime_error handler around the test01 body, so that we exercise at least the exception raising, but then test03 would have to be relaxed, since without even "default", it likely wouldn't meet the tested requirement there. for libstdc++-v3/ChangeLog * testsuite/26_numerics/random/random_device/cons/token.cc: Require effective target feature random_device. Diff: --- libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc b/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc index defb8d58c58..105ae0ba877 100644 --- a/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc +++ b/libstdc++-v3/testsuite/26_numerics/random/random_device/cons/token.cc @@ -1,4 +1,5 @@ // { dg-do run { target c++11 } } +// { dg-require-effective-target random_device } // { dg-require-cstdint "" } // // 2008-11-24 Edward M. Smith-Rowland <3dw4rd@verizon.net>