public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r10-9602] libstdc++: Enforce copyable/movable checks in std::atomic Date: Mon, 29 Mar 2021 20:04:07 +0000 (GMT) [thread overview] Message-ID: <20210329200407.A25E83851C3E@sourceware.org> (raw) https://gcc.gnu.org/g:8c1347013941b49c861d3e3a027195cf4a3409f4 commit r10-9602-g8c1347013941b49c861d3e3a027195cf4a3409f4 Author: Jonathan Wakely <jwakely@redhat.com> Date: Tue Jun 16 22:34:55 2020 +0100 libstdc++: Enforce copyable/movable checks in std::atomic C++20 adds some new preconditions to std::atomic, which weren't previously checked by our implementation. * include/std/atomic (atomic): Add static assertions. * testsuite/29_atomics/atomic/requirements/types_neg.cc: New test. (cherry picked from commit cc799df98f6eaf73763a069f7854e490a0416573) Diff: --- libstdc++-v3/include/std/atomic | 7 ++++ .../29_atomics/atomic/requirements/types_neg.cc | 43 ++++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/libstdc++-v3/include/std/atomic b/libstdc++-v3/include/std/atomic index a455286a784..2161cbed0d2 100644 --- a/libstdc++-v3/include/std/atomic +++ b/libstdc++-v3/include/std/atomic @@ -198,6 +198,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION static_assert(sizeof(_Tp) > 0, "Incomplete or zero-sized types are not supported"); +#if __cplusplus > 201703L + static_assert(is_copy_constructible_v<_Tp>); + static_assert(is_move_constructible_v<_Tp>); + static_assert(is_copy_assignable_v<_Tp>); + static_assert(is_move_assignable_v<_Tp>); +#endif + public: atomic() = default; ~atomic() noexcept = default; diff --git a/libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc b/libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc new file mode 100644 index 00000000000..4c58a9deba2 --- /dev/null +++ b/libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc @@ -0,0 +1,43 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-options "-std=gnu++2a" } +// { dg-do compile { target c++2a } } + +#include <atomic> + +std::atomic<const int> a; // { dg-error "here" } + +struct MoveOnly +{ + MoveOnly() = default; + MoveOnly(MoveOnly&&) = default; + MoveOnly& operator=(MoveOnly&&) = default; +}; +std::atomic<MoveOnly> b; // { dg-error "here" } + +struct NoMove +{ + NoMove() = default; + NoMove(const NoMove&) = default; + NoMove& operator=(const NoMove&) = default; + NoMove(NoMove&&) = delete; + NoMove& operator=(NoMove&&) = delete; +}; +std::atomic<NoMove> c; // { dg-error "here" } + +// { dg-error "static assertion failed" "" { target *-*-* } 0 }
reply other threads:[~2021-03-29 20:04 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210329200407.A25E83851C3E@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).